GetAll now uses Options for it's Options #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jertel
reviewed
May 31, 2024
|
|
||
| type GetAllOption func(query string, schemaPrefix string) string | ||
|
|
||
| func WithEngine(engine EngineName) GetAllOption { |
There was a problem hiding this comment.
Are the other unit tests already covering these returned strings?
There was a problem hiding this comment.
Not as directly as I'd like. I'll add unit tests to the options.
Instead of always accepting engine, isEnabled, and isCommunity, GetAllDetections now accepts a variable number of options. Previous call sites have been updated to do the same thing with the new approach. Updated tests.
coreyogburn
force-pushed
the
cogburn/get-all-cleanup
branch
from
31a0cf3 to
ab1fa7d
Compare
jertel
approved these changes
May 31, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of always accepting engine, isEnabled, and isCommunity, GetAllDetections now accepts a variable number of options. Previous call sites have been updated to do the same thing with the new approach. Updated tests.