Respect User Input #446
Merged
Respect User Input #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I added the new logic for a suricata detection to only update the enabled/disabled pillars if the sid is present in those pillars I forgot to add a way to breakthrough when it's present. Now we mark on the context if the change originated from a user action (incoming web requests are user actions, syncing community rules is not) and the suricata engine respects that flag. Also found a TODO in bulk update about permissions. Added the permission check. Updated tests.
jertel
approved these changes
Apr 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I added the new logic for a suricata detection to only update the enabled/disabled pillars if the sid is present in those pillars I forgot to add a way to breakthrough when it's present. Now we mark on the context if the change originated from a user action (incoming web requests are user actions, syncing community rules is not) and the suricata engine respects that flag.
Also found a TODO in bulk update about permissions. Added the permission check.
Updated tests.