Smarter YARA Imports #440
Merged
Smarter YARA Imports #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YARA files often contain multiple rules. If any of those rules need to import anything, they're imported once at the top of the file. Now, as SOC parses files it retains those imports and re-adds them to rules as it individualizes them making sure to only add the imports that are actually referenced.
jertel
approved these changes
Apr 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YARA files often contain multiple rules. If any of those rules need to import anything, they're imported once at the top of the file. Now, as SOC parses files it retains those imports and re-adds them to rules as it individualizes them making sure to only add the imports that are actually referenced.