Cleanup for Cypress Tests #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way the visual glitch was fixed used an async function. Cypress and async functions don't always play well together, occasionally causing the function to be called twice. Handling the async with the Promise approach solves the visual glitch while allowing cypress to behave more predictably. Some casing changes in the UI tripped up the backend, the backend now normalizes the data it assumed was normalized. Moved the check for 206 when saving a detection down so we are either showing the warning or the successful popup, not both.
jertel
approved these changes
Apr 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way the visual glitch was fixed used an async function. Cypress and async functions don't always play well together, occasionally causing the function to be called twice. Handling the async with the Promise approach solves the visual glitch while allowing cypress to behave more predictably.
Some casing changes in the UI tripped up the backend, the backend now normalizes the data it assumed was normalized.
Moved the check for 206 when saving a detection down so we are either showing the warning or the successful popup, not both.