Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added data-aid attr to new elements #401

Merged
merged 2 commits into from
Mar 29, 2024
Merged

Conversation

coreyogburn
Copy link
Contributor

No description provided.

html/index.html Outdated
@@ -370,12 +370,16 @@ <h2 v-text="i18n[category]"></h2>
<v-select :disabled="loading()" @change="saveTimezone" v-model="zone" :items="$root.timezones" :hint="i18n.timezoneHelp" persistent-hint prepend-icon="fa-user-clock"></v-select>
</span>
<div v-if="isCategory('detections')" class="manual-sync">
<div>
<div data-aid="detections_manualsync_engine">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a _select suffix on this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

data-aid name change.

The spans were messing the styles, updated so the buttons still look good.
@coreyogburn coreyogburn merged commit baf2250 into 2.4/dev Mar 29, 2024
3 checks passed
@coreyogburn coreyogburn deleted the cogburn/missing-data-aid branch March 29, 2024 19:19
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants