Cogburn/detection tests #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't show the title on the Detection Create page. Added a few classes and IDs to help tests. When extracting references, check URLs with Regex so we don't turn plain text into a hyperlink. Fixed a bug where extracting logic wouldn't extract anything if the unindent process didn't unindent anything. When extracting details from sigma rules, extract description too if present. Better logic around extracting yara logic. The `strings:` section is useful but not required. If not found, fallback to looking for `condition:` which is required.
Stopped prefilling the author field when we create the detection model. Instead, add the author to new detections right before we save them. Fixed an issue where non-URL Suricata references where showing up as hyperlinks. Some whitespace trimming in a few places. Fix for extractedLogic not being set if unindenting is unnecessary. The language dropdown entries are now displayed capitalized. Values are still lowercase. Cleaning up overrides turned into a function for testing.
…nstore. The handler should check for all the ways the request will fail. When everything succeeds, the store should do all the manipulation. This also prevents a redundant call to the DB for the existing detection. Removed "tautologies" that the linter was pointing out. Moved another validator from Casestore to Detectionstore for validating a Detection's tags. Fixed a bug when validating the ruleset of a detection. When validating a detection, check the language against the engine to be sure it's a valid pairing. DoesTemplateExist now considers any 2XX successful instead of just 200. Removed a couple redundant auth checks. Updated Casestore tests to have unique test names with Detectionstore and to fix tests that fail from an introduced change. ValidateStringArray was assuming the label was "Tags" even though a label was passed in, but the value was "tags". Detectionstore tests. TODO: More Detectionstore tests.
jertel
approved these changes
Mar 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.