ECT-1384 Canonicalize Fix #8
Open
+5
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ned SAML request that has an inclusive_namespaces canonicalization algorithm
arolling-sa
approved these changes
Mar 29, 2023
|
Should we close this and revisit later when there's better support of the updated Nokogiri in the SAML gem? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes and issue caused by a change to the Nokogiri gem which caused an error while trying to verify signed SAML requests leading to this exception being raised during signature verification:
RuntimeError: This canonicalizer does not support this operationSee here for details of the Nokogiri update.