FreeBSD little build fix proposal. #678
Conversation
tsc/mruby_tsc_build_config.rb
Outdated
| @@ -43,7 +43,11 @@ | |||
| end | |||
|
|
|||
| MRuby::Build.new do |conf| | |||
| toolchain :gcc | |||
| if RUBY_PLATFORM !~ /freebsd/ | |||
There was a problem hiding this comment.
Nit: while we're doing this anyway, maybe also check for openbsd here?
|
Very nice. Thank you. I approve this, but it would be nice if someone could check if compiling works afterwards still on MacOS. |
|
@refi64 Consider cherry-picking this into the release branch for 2.1.0. It should apply nearly as-is and does not change anything that could possible make problems I think. |
|
Side note: would be nice to update the mruby dependency at some point. this https://github.com/mruby/mruby/blob/1c09046c13fc0a763583c6da0f1d350f6c41c4ca/mrbgems/mruby-compiler/core/keywords probe signatures are not correct (unsigned int instead of size_t) and has been fixed since. |
|
Thanks for the heads-up. I will take care of mruby updates in the |
No description provided.