shift-app-expo_17_68_landing-page-connect-login-button-to-login-page #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created the a landing.tsx file; included a link to the Landing page on the index.tsx file; routed the Login button on the lainding.tsx to the Login page
katrina-l-hill
requested review from
cshimm,
bennettsf,
IsaacJrTypes,
nwm516,
BradleyCharles,
JesseCaddell,
larsswenson,
MiguelQuintana1 and
JoyZhang2023
MiguelQuintana1
approved these changes
Feb 1, 2025
There was a problem hiding this comment.
I tested the pull request that resolved issue #68 on Web and iPhone Simulator, and it works as intended. Good job, Katrina.
GMT20250201-195307_Clip_Miguel.Quintana.s.Clip.02_01_2025.mp4
nwm516
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
@katrina-l-hill , great work! I was able to replicate the same results via Android Emulator:
Katrina.-.Landing.to.Login.mp4
Thank you for your contribution to this application! I appreciate it!
IsaacJrTypes
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request!
Resolves issue 68
This pull request adds a link to the Landing page on the index.tsx. In addition, once clicked, the route for the Login button on the landing.tsx has been connected to the Login page.
Video walkthrough:
2025-01-31.13-11-48.mp4