-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating_patch_dependencies_only_sprint14_#572_PR #573
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on my end, didn't run into any issues when testing or running the server as a test.
You seem to have a check that is still pending for on pull request / build-and-test Expected
part. I'm not too familiar with CI/CD stuff but I did check your .yml file for on pull request in the github workflow section and the set_status_check section is commented out. That might possibly be the issue but just guessing here, maybe try uncommenting that section to see if that fixes the issue. Otherwise, it might be another CI/CD issue. Not safe to approve yet until check is completed. I'll try to help as best I can if you need it @miqo1385.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In regards to the on pull request / build-and-test CI issue... I just updated the CI/CD actions yesterday. This should solve our problem. For some reason the action was not triggering. The only solution I have found so far is to make a new PR and see if it triggers. I was able to merge my changes without the build-and-test yesterday, so I'll request a second set of eyes in regards to that @bcko @taylorpapke but I am going to approve this PR once it is up to date with main! Looks good, thank you for your hard work!
Thank you Jesse, I will do a new PR for these changes. |
Great work on the patch dependency updates! Everything looks good and runs smoothly on my end without any issues during testing. The updates are well-organized and keep things clean while addressing the patch updates effectively. I did notice that the "build-and-test" CI step is still pending. It might be worth taking another look at the .yml file, specifically the commented-out set_status_check section, to see if re-enabling that resolves the problem. Overall, I think this is a solid update, and once the CI step is sorted, it should be good to go. Also, I found a helpful link about handling dependency updates or similar workflows : Semantic Versioning Guide for some helpful tips and best practices. |
I updated all the minor dependencies suggested and ran as it should on my end.
This is a pull request!
Resolves issue #572
It was more challenging than we anticipated the last time we attempted to update the dependencies in these projects. and it appears that the job was put on hold. In order to begin moving cautiously with minor and big upgrades, I started small by changing the patch dependencies alone.
These dependencies (minor and major) need to be updated following patch updates.