Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating_patch_dependencies_only_sprint14_#572_PR #573

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

miqo1385
Copy link
Contributor

@miqo1385 miqo1385 commented Nov 12, 2024

This is a pull request!

Resolves issue #572

It was more challenging than we anticipated the last time we attempted to update the dependencies in these projects. and it appears that the job was put on hold. In order to begin moving cautiously with minor and big upgrades, I started small by changing the patch dependencies alone.
These dependencies (minor and major) need to be updated following patch updates.

image

@miqo1385 miqo1385 requested a review from a team as a code owner November 12, 2024 04:23
@miqo1385 miqo1385 requested review from bcko, cshimm, IsaacJrTypes, keiffer213, heosman, taylorpapke and ParysUnangst and removed request for a team November 12, 2024 04:23
Copy link

socket-security bot commented Nov 12, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@mui/[email protected] None +2 18.3 MB diegoandai
npm/@mui/[email protected] None +2 395 kB diegoandai
npm/@mui/[email protected] environment +24 10.9 MB diegoandai
npm/@mui/[email protected] environment +10 761 kB diegoandai
npm/@mui/[email protected] environment +22 7.37 MB jcquintas
npm/@tanstack/[email protected] environment +1 2.54 MB tannerlinsley
npm/@testing-library/[email protected] None +11 2.42 MB brrianalexis, cmckinstry, dfcook, ...13 more
npm/@types/[email protected] Transitive: environment, filesystem, unsafe +41 1.72 MB types
npm/@types/[email protected] None +1 2.36 MB types
npm/@types/[email protected] None 0 0 B
npm/@types/[email protected] None +2 1.69 MB types
npm/[email protected] Transitive: environment, filesystem +41 3.93 MB testing-library-bot
npm/[email protected] environment, network Transitive: filesystem, shell +17 10.5 MB vkarpov15
npm/[email protected] environment, network Transitive: filesystem, shell +14 4.36 MB balazsorban
npm/[email protected] environment, filesystem +3 372 kB ai
npm/[email protected] environment +7 442 kB siamahnaf
npm/[email protected] environment Transitive: eval, filesystem, shell +28 181 MB lovell
npm/[email protected] Transitive: environment, filesystem, network, shell, unsafe +89 14.4 MB adamwathan, malfaitrobin, reinink
npm/[email protected] None 0 22.4 MB typescript-bot

🚮 Removed packages: npm/@mui/[email protected], npm/@mui/[email protected], npm/@mui/[email protected], npm/@mui/[email protected], npm/@mui/[email protected], npm/@tanstack/[email protected], npm/@testing-library/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@el-riber el-riber self-requested a review November 13, 2024 08:04
Copy link
Contributor

@el-riber el-riber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here it worked very well! good job
Screenshot 2024-11-13 at 12 03 30 AM

@nhapham03
Copy link
Contributor

image
Works on my end. LGTM!

Copy link
Contributor

@Asfand00 Asfand00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on my end, didn't run into any issues when testing or running the server as a test.
nsc-events-dependecy-update-test

You seem to have a check that is still pending for on pull request / build-and-test Expected part. I'm not too familiar with CI/CD stuff but I did check your .yml file for on pull request in the github workflow section and the set_status_check section is commented out. That might possibly be the issue but just guessing here, maybe try uncommenting that section to see if that fixes the issue. Otherwise, it might be another CI/CD issue. Not safe to approve yet until check is completed. I'll try to help as best I can if you need it @miqo1385.

Copy link
Contributor

@JesseCaddell JesseCaddell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In regards to the on pull request / build-and-test CI issue... I just updated the CI/CD actions yesterday. This should solve our problem. For some reason the action was not triggering. The only solution I have found so far is to make a new PR and see if it triggers. I was able to merge my changes without the build-and-test yesterday, so I'll request a second set of eyes in regards to that @bcko @taylorpapke but I am going to approve this PR once it is up to date with main! Looks good, thank you for your hard work!

@el-riber el-riber self-requested a review November 15, 2024 01:37
@miqo1385
Copy link
Contributor Author

Thank you Jesse, I will do a new PR for these changes.

@Diego-Cano
Copy link

Great work on the patch dependency updates! Everything looks good and runs smoothly on my end without any issues during testing. The updates are well-organized and keep things clean while addressing the patch updates effectively. I did notice that the "build-and-test" CI step is still pending. It might be worth taking another look at the .yml file, specifically the commented-out set_status_check section, to see if re-enabling that resolves the problem.

Overall, I think this is a solid update, and once the CI step is sorted, it should be good to go. Also, I found a helpful link about handling dependency updates or similar workflows : Semantic Versioning Guide for some helpful tips and best practices.

Screenshot 2024-11-17 at 9 29 58 AM

miqo1385 and others added 2 commits November 17, 2024 12:43
I updated all the minor dependencies suggested and ran as it should on my end.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants