Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nsc-events-nestjs-12-141-upgrade-packages-and-node-LTS #143

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

bennettsf
Copy link
Contributor

@bennettsf bennettsf commented Oct 19, 2024

Resolves #141 (continuation of @Alzavio 's issue)
This PR dependencies/packages as well as node to 20.xx LTS

I've done some testing to make sure all current features are working properly and there are no dependency conflicts with the upgrades.

Also ran our current tests (npm run test) :
image

I'm going to spend more time testing this weekend to make sure I didn't miss anything. If you have any recommendations or concerns please drop a comment.

It's recommended to test this in conjunction with the frontend dependency upgrades PR (located here: SeattleColleges/nsc-events-nextjs#560) although probably not necessary.

Copy link

socket-security bot commented Oct 19, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@nestjs/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +242 65 MB kamilmysliwiec, nestjscore
npm/@nestjs/[email protected] None +4 588 kB nestjscore
npm/@nestjs/[email protected] environment, filesystem +4 1.66 MB nestjscore
npm/@nestjs/[email protected] Transitive: environment, filesystem, network, shell +18 1.5 MB nestjscore
npm/@nestjs/[email protected] Transitive: environment, eval, filesystem, network, unsafe +85 2.77 MB kamilmysliwiec, nestjscore
npm/@nestjs/[email protected] Transitive: environment, eval, filesystem, network, unsafe +64 5.61 MB nestjscore
npm/@types/[email protected] Transitive: environment, filesystem, unsafe +49 1.9 MB types
npm/@types/[email protected] None 0 3.78 MB types
npm/@typescript-eslint/[email protected] Transitive: environment, filesystem +45 6.83 MB jameshenry
npm/@typescript-eslint/[email protected] Transitive: environment, filesystem +34 2.59 MB jameshenry
npm/[email protected] None 0 19.7 kB lydell
npm/[email protected] environment, filesystem Transitive: eval, shell, unsafe +97 10.6 MB eslintbot
npm/[email protected] environment, network Transitive: filesystem +23 9.91 MB vkarpov15
npm/[email protected] environment, filesystem, unsafe Transitive: eval, network, shell +153 15.9 MB kul
npm/[email protected] filesystem Transitive: environment, eval, shell, unsafe +79 14.7 MB johnnyreilly
npm/[email protected] None 0 39.2 MB typescript-bot

🚮 Removed packages: npm/@nestjs/[email protected], npm/@nestjs/[email protected], npm/@nestjs/[email protected], npm/@nestjs/[email protected], npm/@nestjs/[email protected], npm/@nestjs/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Copy link

@Diego-Cano Diego-Cano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be working fine based on initial tests.

@Diego-Cano
Copy link

Everything seems to be working fine based on initial tests. The PR touches key packages like @nestjs/cli and @typescript-eslint/parser, which should improve performance and security. The upgrades are looking great with no obvious issues or conflicts. It might be worth testing on a couple of different Node.js versions to ensure the upgrades work across environments, especially for the critical dependencies accordingly. Some manual testing would also help cover any missed cases.

I found a useful link on : Best Practices and Benefits for Maintaining Up-to-Date Dependencies

1

Copy link

@Asfand00 Asfand00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good, the testing went well on my end, I also tested in conjunction with the other branch you mentioned:
nsc-events-nest-test

I did encounter a console.warn for the API key (but it's probably on my end maybe):
nsc-events-nest-warning

only minor change I would request is getting rid of the karats ^ in your package.json since were trying to enforce that from what @bcko said:
nsc-events-nest-dependencies

@bennettsf bennettsf changed the title nsc-events-nextjs-12-141-upgrade-packages-and-node-LTS nsc-events-nestjs-12-141-upgrade-packages-and-node-LTS Oct 22, 2024
Copy link

@Asfand00 Asfand00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great, Testing the pages went the same way but the caret removal is much appreciated, Sorry for the late check on your new changes, Thanks @bennettsf
nsc-events-nestjs-package json

@bennettsf bennettsf merged commit 8a4bce4 into main Oct 29, 2024
3 checks passed
@bennettsf bennettsf deleted the chore-141-upgrade-packages-and-node-version branch October 29, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade packages
3 participants