-
Notifications
You must be signed in to change notification settings - Fork 3
nsc-events-android_5_233_add-pronouns-field #236
Conversation
@tinpham5614 How would we go about connecting the frontend to the backend for android? |
Are you referring to the implementation or running the app for testing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tinpham5614 Thanks! Yes, I was referring to the implementation. It appears that you can login and possibly create events but it still shows sample events and users.
@MaddasaHatter Looks good to me! I am seeing the pronouns field and am able to enter text including numbers and special characters:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Because this is for the android and we don't expect folks from the junior cohort to interact with this repo I am merging without waiting for a 3rd review to be made since this more than fulfills the old requirements, with 2 approvals, 2 coming from leadership. |
Resolves #233
This PR adds a pronouns field to the sign-up page
https://github.com/SeattleColleges/nsc-events-android/assets/52189566/c32cd6b5-4eb6-4220-9d0d-87791a0faecf
Remember to:
Add reviewers