Skip to content
This repository has been archived by the owner on Jan 10, 2025. It is now read-only.

nsc-events-android_5_233_add-pronouns-field #236

Merged
merged 3 commits into from
May 2, 2024

Conversation

LilithLucifer3x6
Copy link
Contributor

@LilithLucifer3x6 LilithLucifer3x6 commented Apr 28, 2024

Resolves #233
This PR adds a pronouns field to the sign-up page
https://github.com/SeattleColleges/nsc-events-android/assets/52189566/c32cd6b5-4eb6-4220-9d0d-87791a0faecf

Remember to:
Add reviewers

@LilithLucifer3x6 LilithLucifer3x6 marked this pull request as draft April 28, 2024 02:43
@LilithLucifer3x6 LilithLucifer3x6 self-assigned this Apr 28, 2024
@LilithLucifer3x6 LilithLucifer3x6 added enhancement New feature or request Sprint 5 labels Apr 28, 2024
@LilithLucifer3x6 LilithLucifer3x6 changed the title I added a pronouns field below the name fields in the sign up form. nsc-events-android-5-233-Add pronouns field Apr 28, 2024
@taylorpapke taylorpapke marked this pull request as ready for review April 28, 2024 19:47
@taylorpapke
Copy link
Contributor

@tinpham5614 How would we go about connecting the frontend to the backend for android?

@tinpham5614
Copy link
Contributor

@tinpham5614 How would we go about connecting the frontend to the backend for android?

Are you referring to the implementation or running the app for testing?
For the implementation, I don't have an instruction but official documentation.
Here is the link
For testing, we just run the Android app and backend NestJs the same as the web version.

Copy link
Contributor

@taylorpapke taylorpapke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tinpham5614 Thanks! Yes, I was referring to the implementation. It appears that you can login and possibly create events but it still shows sample events and users.

@MaddasaHatter Looks good to me! I am seeing the pronouns field and am able to enter text including numbers and special characters:
Screenshot 2024-04-30 at 3 35 13 AM

Copy link
Contributor

@heosman heosman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@heosman heosman changed the title nsc-events-android-5-233-Add pronouns field nsc-events-android_5_233_add-pronouns-field May 1, 2024
@brinkbrink
Copy link
Contributor

Because this is for the android and we don't expect folks from the junior cohort to interact with this repo I am merging without waiting for a 3rd review to be made since this more than fulfills the old requirements, with 2 approvals, 2 coming from leadership.

@brinkbrink brinkbrink merged commit 4fa4840 into main May 2, 2024
2 checks passed
@brinkbrink brinkbrink deleted the feature-232-adddashboardlink-01 branch May 2, 2024 19:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request Sprint 5
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Sign up Page: Add pronouns field
5 participants