Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

belindas-closet-nextjs_13_553_form-page #554

Merged
merged 6 commits into from
Nov 18, 2024

Conversation

nhapham03
Copy link
Contributor

@nhapham03 nhapham03 commented Nov 8, 2024

Resolves #553
I created a simple form page to hold students data.
Screenshot 2024-11-08 171953

@nhapham03 nhapham03 added enhancement New feature or request Fall This is an issue for Fall students Sprint 13 labels Nov 8, 2024
@nhapham03 nhapham03 self-assigned this Nov 8, 2024
@nhapham03 nhapham03 linked an issue Nov 8, 2024 that may be closed by this pull request
@Diego-Cano
Copy link
Contributor

This draft PR is for creating a basic form page to capture student information, but right now, the app/form-page/page.tsx file is still empty. It has one failing check related to build-and-test, while the other checks, like Socket Security and CodeQL scans, have passed, which at least shows there are no security issues or dependency changes.

There's still work to be done here to actually add the form fields as outlined in the user story. Automated checks are useful here to make sure we’re not introducing any vulnerabilities, even if the code is minimal at this stage. Here is an useful resource for Form design best practices

Screenshot 2024-11-10 at 10 34 52 AM

@nhapham03 nhapham03 marked this pull request as ready for review November 11, 2024 18:22
Copy link
Contributor

@Asfand00 Asfand00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm seeing the same changes as you are @nhapham03.
belindas-form-page

Didn't come across any concerning issues, and package.json is fine too. Nice Work!

Copy link
Collaborator

@keiffer213 keiffer213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks for your work on this!

@keiffer213 keiffer213 merged commit e4311fb into main Nov 18, 2024
6 checks passed
@keiffer213 keiffer213 deleted the feature-553-create-form-page-01 branch November 18, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Fall This is an issue for Fall students Sprint 13
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Create a Basic Form Page
4 participants