-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore belindas nextjs update api evironment #525
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job. We would need to document this as well.
How would I test this PR locally? Changing the API address in the env works fine, but I notice that there's issues with signing in and data not being fetched. Usually, I would comment out the env API URL lines on the Sign In page and next.config.js, but how would I do that in this PR? |
@intisarosman1 I think the issue might the localhost address does not contain the same port value as the backend server. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @IsaacJrTypes, I was able to get it working!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me as well! Thanks for this!
This PR contains a quality of life update! Now you can set the API address from your .env file. If the developer is using a localhost based API address, the API address will be printed to the console.
How to test:
npm run dev
and run backend