-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
belindas-closet-nextjs_10_511_bug-fix-unit-test-errors-signup-page #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asfand00
added
dependencies
Pull requests that update a dependency file
Sprint 10
labels
Jul 28, 2024
Asfand00
requested review from
bcko,
cshimm,
bennettsf,
IsaacJrTypes,
nwm516,
keiffer213,
tinpham5614,
heosman,
intisarosman1,
nickolasram,
taylorpapke,
larsswenson,
gitbiruk2010,
Robel-003 and
a team
July 28, 2024 06:05
intisarosman1
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ken-ni
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #511
Reference image:
This PR is for fixing the console errors that appear for the signup page after running
npm test
or by another command. Some investigation has been done to try and find the root cause for the errors and from my findings and with the help of @IsaacJrTypes we discovered it was a dependency issue with react and next. it seems to be a common issue with react and next so to resolve this we downgrade react and react-dom to version 18.2 and I had updated next and next-auth to the latest version. You can find more details of this on the issue page #511.To clarify on why I upgraded next and next-auth to latest:
The reason is because on my end simply downgrading react to 18.2 didn't solve the console errors completely and I was still getting errors for the sign-up page so I had an idea to try upgrading next to 14.2.4 and had next-auth upgraded to its latest version at 4.24.7 because the previous version was incompatible with next 14.2.4.
previous versions:
next - 13.5.6
next-auth - 4.22.1
react - 18.3.1
updated versions:
next - 14.2.4
next-auth - 4.24.7
react - 18.2.0
Here are the patch notes for next 14.2 and the specific 14.2.4 release notes on GitHub, links as reference:
https://nextjs.org/blog/next-14-2
https://github.com/vercel/next.js/releases?q=14.2.4&expanded=true
This fix will also correct most of the other console errors that appear
To test: checkout my branch and run
npm test
and you should not see console errors appear for the sign up pageAfter the dependency fix, I still had console errors popping up for creator page and contact page (both of which I worked on in the past) so I was trying to fix those errors if possible, I only managed to correct the errors for the contact page but the creator page will still display this console error when testing:
I had trouble trying to fix this error (out of my depth for that one) needs more time investigating on my end, if anyone has ideas, I'm open to it otherwise it's not a big deal at the moment.
We can probably create a separate issue for this one, @keiffer213 if you want to add it to the sprint board. The main issue for the sign-up page is still solved regardless.
for the separate issue regarding the creator page test errors we will use this PR #520 and issue #511 as resources to help the next developer.