-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
< Belindas-closet-nextjs> _ <8 > _ < 444> _ < archive products - fixed> #447
Conversation
… products. I made all the codes necessary to run the program. This includes the page, the api to make the connection between the images and the page. I made all the necessary changes for the code to run in Typescript.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not to dog pile and I don't know if you have had a chance to update this yet but I don't see the folder for the page when I checkout your branch either. |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected], npm/[email protected], npm/[email protected] |
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is telemetry?This package contains telemetry which tracks how it is used. Most telemetry comes with settings to disable it. Consider disabling telemetry if you do not want to be tracked. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
This PR doesn't include the package.json and the conflicts that arise are too complex to resolve. I think an easy fix would be to create a new branch from main and copy over the single page.tsx. A good example of how this should look is on the nsc-events website: https://github.com/SeattleColleges/nsc-events-nextjs/blob/main/app/archived-events/page.tsx. |
This is a pull request!
Please use the following format for the title:
< Belindas-closet-nextjs> _ <8 > _ < 444> _ < archive products - fixed>
Please fill out this description with the following:
Resolves <issue #> 444
As a developer I created the page to archive products.
I made all the codes necessary to run the program. This includes the page, the api to make the connection between the images and the page.
I made all the necessary changes for the code to run in Typescript.
ps: I tried to make the pull request through VSC but today it's very slow, so I added the files here directly, I hope it works, if it doesn't work I'll try through VSC again