Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

< Belindas-closet-nextjs> _ <8 > _ < 444> _ < archive products - fixed> #447

Closed
wants to merge 11 commits into from

Conversation

el-riber
Copy link
Contributor

@el-riber el-riber commented Jun 9, 2024

This is a pull request!

Please use the following format for the title:
< Belindas-closet-nextjs> _ <8 > _ < 444> _ < archive products - fixed>

Please fill out this description with the following:
Resolves <issue #> 444
As a developer I created the page to archive products.
I made all the codes necessary to run the program. This includes the page, the api to make the connection between the images and the page.

I made all the necessary changes for the code to run in Typescript.

ps: I tried to make the pull request through VSC but today it's very slow, so I added the files here directly, I hope it works, if it doesn't work I'll try through VSC again

Screenshot 2024-06-09 at 1 47 44 PM Screenshot 2024-06-09 at 12 52 08 PM Screenshot 2024-06-09 at 2 24 40 PM

el-riber added 2 commits June 9, 2024 14:15
… products.

I made all the codes necessary to run the program. This includes the page, the api to make the connection between the images and the page.

I made all the necessary changes for the code to run in Typescript.
@el-riber el-riber linked an issue Jun 9, 2024 that may be closed by this pull request
2 tasks
@el-riber el-riber changed the title Add files via upload < Belindas-closet-nextjs> _ <8 > _ < 444> _ < archive products - fixed> Jun 9, 2024
@taylorpapke taylorpapke requested review from taylorpapke, a team, bcko, cshimm, Exochos, heosman, brinkbrink and Robel-003 and removed request for a team June 9, 2024 21:57
Copy link
Contributor

@taylorpapke taylorpapke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These files need to be under the app folder in a page folder like the other pages:
Screenshot 2024-06-09 at 2 59 35 PM

@el-riber
Copy link
Contributor Author

el-riber commented Jun 9, 2024

But it is just like that, the problem is with the pull request. I will try to fix it

Screenshot 2024-06-09 at 4 41 38 PM Screenshot 2024-06-09 at 4 42 24 PM

@LilithLucifer3x6
Copy link
Contributor

Not to dog pile and I don't know if you have had a chance to update this yet but I don't see the folder for the page when I checkout your branch either.

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] environment, network +14 3.79 MB thvu
npm/[email protected] environment, filesystem, network, shell, unsafe +23 1.2 GB vercel-release-bot
npm/[email protected] environment, filesystem +3 368 kB ai

🚮 Removed packages: npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Telemetry npm/[email protected]
  • Note: Can be disabled by setting the environment variable NEXT_TELEMETRY_DISABLED=1 . See https://nextjs.org/telemetry for more information
Telemetry npm/[email protected]
  • Note: Can be disabled by setting the environment variable NEXT_TELEMETRY_DISABLED=1 . See https://nextjs.org/telemetry for more information

View full report↗︎

Next steps

What is telemetry?

This package contains telemetry which tracks how it is used.

Most telemetry comes with settings to disable it. Consider disabling telemetry if you do not want to be tracked.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@el-riber el-riber requested a review from taylorpapke June 12, 2024 04:53
@el-riber
Copy link
Contributor Author

api test screen..
page test screen

a1 a2

@taylorpapke
Copy link
Contributor

This PR doesn't include the package.json and the conflicts that arise are too complex to resolve.

I think an easy fix would be to create a new branch from main and copy over the single page.tsx. A good example of how this should look is on the nsc-events website: https://github.com/SeattleColleges/nsc-events-nextjs/blob/main/app/archived-events/page.tsx.

@kaimanasse15
Copy link
Contributor

It looks great but I don't see any images?
image

@el-riber
Copy link
Contributor Author

It looks great but I don't see any images? image
you can not see any image because you have to add images to the public/image file so the api will show the images. I hope so. I you see my files is not included the image.

@heosman heosman closed this Jun 26, 2024
@heosman heosman deleted the 444-archived-products-page-fixed branch July 5, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Archived Products Page: Display Archived Items
5 participants