Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

belindas-closet-nextjs_4_249_add-delete-and-archive-buttons-to-product-card #264

Conversation

krayzieeddi
Copy link
Contributor

@krayzieeddi krayzieeddi commented Mar 14, 2024

Resolves #267 #268
Related #249

I have implemented delete and archive functionality to the delete and archive buttons within the product card component.

@krayzieeddi krayzieeddi added enhancement New feature or request Sprint 4 labels Mar 14, 2024
@krayzieeddi krayzieeddi requested a review from a team as a code owner March 14, 2024 00:49
@krayzieeddi krayzieeddi requested review from bcko, Exochos, Seiyaroo, heosman and brinkbrink and removed request for a team March 14, 2024 00:49
@krayzieeddi krayzieeddi linked an issue Mar 14, 2024 that may be closed by this pull request
2 tasks
@heosman heosman changed the title Belinda next js sprint 4 249 add delete and archive buttons to product card belindas-closet-nextjs_4_249_add-delete-and-archive-buttons-to-product-card Mar 14, 2024
Copy link
Contributor

@heosman heosman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both the delete functionality and archive functionality are working, and the changes were reflected in the database.
When I deleted a product:
Screenshot 2024-03-14 100634
When I archived a product:
Screenshot 2024-03-14 100710

I would suggest aligning the buttons better on the product cards so that aren't hovering off.
Screenshot 2024-03-14 101057

Copy link
Contributor

@tinpham5614 tinpham5614 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The UI will be updated on another issue.

@krayzieeddi
Copy link
Contributor Author

I have solved my GPG key issue and all my commits are now verified. Should I merge it myself or someone else should?

@Exochos Exochos merged commit 6a937f9 into main Mar 15, 2024
5 checks passed
@Exochos Exochos deleted the Belinda_NextJS_Sprint_4_249_Add_Delete_and-_archive_buttons_to_productCard branch March 15, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Sprint 4
Projects
Status: Done
4 participants