Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

belindas-closet-nestjs_14_144_removal_of_deprecated_GitHub_actions #145

Merged
merged 6 commits into from
Jan 10, 2025
Merged

belindas-closet-nestjs_14_144_removal_of_deprecated_GitHub_actions #145

merged 6 commits into from
Jan 10, 2025

Conversation

keiffer213
Copy link
Contributor

Resolves #144

This PR fixes github actions that were not working or no longer in our plan.

  • Removal of CD actions
  • Fix of keywords
  • Upgraded version of artifacts from v3 to v4
  • Upgraded ci.yml

Creation on new branch CI passes
image

@keiffer213 keiffer213 added the bug Something isn't working label Nov 25, 2024
@keiffer213 keiffer213 self-assigned this Nov 25, 2024
@keiffer213 keiffer213 requested a review from a team as a code owner November 25, 2024 22:03
@keiffer213 keiffer213 requested review from bcko, nwm516, BradleyCharles, Bejarano03 and JesseCaddell and removed request for a team November 25, 2024 22:03
@keiffer213 keiffer213 linked an issue Nov 25, 2024 that may be closed by this pull request
Removal of deprecated Github Actions - Belindas-nestjs #144
Closed
8 tasks
IsaacJrTypes
IsaacJrTypes approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@IsaacJrTypes IsaacJrTypes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ParysUnangst
Copy link

ParysUnangst commented Dec 12, 2024 •
edited
Loading

Looks good to me Keiffer!

JesseCaddell
JesseCaddell approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@JesseCaddell JesseCaddell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for making these changes!

@JesseCaddell JesseCaddell merged commit 0689081 into main Jan 10, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsaacJrTypes IsaacJrTypes IsaacJrTypes approved these changes

@JesseCaddell JesseCaddell JesseCaddell approved these changes

@bcko bcko Awaiting requested review from bcko bcko is a code owner automatically assigned from SeattleColleges/leadership

@nwm516 nwm516 Awaiting requested review from nwm516 nwm516 is a code owner automatically assigned from SeattleColleges/leadership

@BradleyCharles BradleyCharles Awaiting requested review from BradleyCharles BradleyCharles is a code owner automatically assigned from SeattleColleges/leadership

@Bejarano03 Bejarano03 Awaiting requested review from Bejarano03 Bejarano03 is a code owner automatically assigned from SeattleColleges/leadership

@larsswenson larsswenson Awaiting requested review from larsswenson larsswenson is a code owner automatically assigned from SeattleColleges/leadership

@JoyZhang2023 JoyZhang2023 Awaiting requested review from JoyZhang2023 JoyZhang2023 is a code owner automatically assigned from SeattleColleges/leadership

Assignees

@keiffer213 keiffer213

Labels
bug Something isn't working
Projects
Belinda's Closet
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removal of deprecated Github Actions - Belindas-nestjs
4 participants
@keiffer213 @ParysUnangst @IsaacJrTypes @JesseCaddell