Skip to content
This repository was archived by the owner on Jan 10, 2025. It is now read-only.

belindas-closet-android_5_271_add-profile-dropdown #278

Merged
merged 8 commits into from
Apr 24, 2024

Conversation

heosman
Copy link
Contributor

@heosman heosman commented Apr 23, 2024

Resolves #271

This PR adds a profile dropdown to every page (except the Sign Up, Login, Forgot Password, and ResetPassword pages). On pages other than the AdminView, CreatorView, Add Product, and Edit User Role pages, I added role-based access to the profile dropdown so that only users signed in as admin and creators would be able to see the profile dropdown. Pressing the profile dropdown opens a dropdown menu with a dashboard link and sign out link. The dashboard link is currently not functioning. Below are some screenshots of some of the pages.

Home page (not logged in as admin or creator):
home page not logged in

Home page (logged in as admin or creator):
home page logged in as admin

Admin page:
adminview page

Product Detail page:
productdetail page

Related to #270

@heosman heosman self-assigned this Apr 23, 2024
@heosman heosman requested a review from a team as a code owner April 23, 2024 04:32
@heosman heosman requested review from bcko, Exochos, Seiyaroo, tinpham5614, brinkbrink, taylorpapke and Robel-003 and removed request for a team April 23, 2024 04:32
@heosman heosman enabled auto-merge (squash) April 23, 2024 04:39
Copy link
Contributor

@taylorpapke taylorpapke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! The dropdown works for me on all of the pages you mentioned while logged in as a creator/admin. A couple things I noticed which are unrelated to this PR is that the add product page is not available in both admin and creator pages. Also, the dashboard button on the dropdown crashes the app.

@heosman
Copy link
Contributor Author

heosman commented Apr 23, 2024

Looks great! The dropdown works for me on all of the pages you mentioned while logged in as a creator/admin. A couple things I noticed which are unrelated to this PR is that the add product page is not available in both admin and creator pages. Also, the dashboard button on the dropdown crashes the app.

@taylorpapke I also noticed that the Add Product can't be accessed without changing ScreenMain to open to that page. The dashboard page is probably crashing because the dashboard page doesn't exist yet.

Copy link
Contributor

@Robel-003 Robel-003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Once I logged in as an admin or creator, I was able to view the dropdown menu in all the pages you specified. Like you stated, the dashboard link isn't functional but I was able to sign-out with the sign-out link.

Copy link
Contributor

@intisarosman1 intisarosman1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When logged in as a creator, I can see the profile dropdown when I press the profile icon. LGTM
Screenshot 2024-04-23 213213

@heosman heosman merged commit cda184b into main Apr 24, 2024
1 check passed
@heosman heosman deleted the feature-271-create-profile-dropdown-01 branch April 24, 2024 04:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Nav Bar: Create profile dropdown
4 participants