Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

belinda-closet-android-02-224-add_product_functionality #237

Merged
merged 6 commits into from
Jan 4, 2024

Conversation

tinpham5614
Copy link
Contributor

@tinpham5614 tinpham5614 commented Dec 7, 2023

Resolves: #224
This PR will do:

  1. The files were restructured to match the backend (auth, product, user).
  2. Added Product Request and Response DTO.
  3. Added Product Service and its implementation.
  4. Created and called the addProduct function on the AddProduct page.

Demo:

Logcat Screenshot:
image

Video:

Running.Devices.-.belindas_closet.2023-12-07.09-14-32.mp4

Database Screenshot:
image

Copy link
Contributor

@taylorpapke taylorpapke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked for me. When I was logged out or logged in with the user role, it would not let me add a product and would redirect me to the login page (as expected).

It allowed me to add a product for the admin role but not the creator role. In a future iteration, the creator role should also be given access to add product.

@tinpham5614
Copy link
Contributor Author

This worked for me. When I was logged out or logged in with the user role, it would not let me add a product and would redirect me to the login page (as expected).

It allowed me to add a product for the admin role but not the creator role. In a future iteration, the creator role should also be given access to add product.

I will change the logic to make it works for both AMIN and CREATOR

@tinpham5614
Copy link
Contributor Author

To enable CREATOR to add new products, we also need to assign CREATOR role in the backend.

products.controller.ts

image

@brinkbrink brinkbrink merged commit 3a94c92 into main Jan 4, 2024
1 check passed
@brinkbrink brinkbrink deleted the feature-224-add-product-functionality-01 branch January 4, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
3 participants