belindas-closet-android_4_235_edit-option-visiblity #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intisarosman1
requested review from
Annelisebx,
tinpham5614,
heosman,
brinkbrink,
brandondombrowsky,
taylorpapke and
MuhammadNSC
taylorpapke
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
Awesome work! When user with admin and creator roles are signed in, The edit button appears on both the IndividualProduct.kt and the ProductDetail.kt.
When not signed in (or signed in with user role), the edit button does not appear on the IndividualProduct.kt and ProductDetail.kt.
brinkbrink
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #235
This PR makes it so that the edit option (pencil icon on Product Details page and Individual Products page) is only available to admins and creators and not to users without the appropriate role or users that are signed out. They will not be able to have access to editing options or altering the products listed.
Related to User Story #163