-
Notifications
You must be signed in to change notification settings - Fork 7
Conversation
…oset-android into enhancement-167-edit-user-role-01
…oset-android into enhancement-167-edit-user-role-01
…e button leads to new screen. no data visible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks amazing! In future iterations, I think we can change standard to just User to match the role it represents (or Creator). Also, we can probably get rid of the NSC Logo in the top left since this is non-customer facing and the back button is covering it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work here. Taylor's suggestions for future iterations make sense. I also appreciate the comments in the code, makes it really easy to read through the logic and understand what you did...which makes it easier to review!
@Annelisebx Looks like there are still issues with signing commits here but given it's the last week of the quarter I'm just going to force merge. |
Resolves Issue 167 - EDIT USER ROLE: Add Page and List All Users/Roles
As a developer I added a page that (in theory) lists all users of the app and their role and allows admins to edit the role of each user.
Completed:
Next Steps for Future PR:
As a an admin, I would like the edit icon to allow me to update and/or change the user's role.