Skip to content
This repository was archived by the owner on Jan 10, 2025. It is now read-only.

belindas-android_4_167_edit-user-role #234

Merged
merged 11 commits into from
Dec 6, 2023

Conversation

Annelisebx
Copy link
Contributor

@Annelisebx Annelisebx commented Dec 6, 2023

Resolves Issue 167 - EDIT USER ROLE: Add Page and List All Users/Roles

As a developer I added a page that (in theory) lists all users of the app and their role and allows admins to edit the role of each user.

Completed:

  • New screen listing users
  • List all users first & last names and their role
  • Edit icon added to each user card (non functioning)
  • Navigation scaffold with arrow back to Admin page
  • See Video Here
    image

Next Steps for Future PR:

As a an admin, I would like the edit icon to allow me to update and/or change the user's role.

  • Add functionality to icon
  • Remove logo
  • Change 'Standard' user role to 'Creator' or 'User'
  • Edit layout so user cards do not overlap and are the same size

@Annelisebx Annelisebx added enhancement New feature or request Sprint 4 labels Dec 6, 2023
@Annelisebx Annelisebx self-assigned this Dec 6, 2023
@Annelisebx Annelisebx requested a review from a team as a code owner December 6, 2023 00:39
@Annelisebx Annelisebx linked an issue Dec 6, 2023 that may be closed by this pull request
4 tasks
@Annelisebx Annelisebx marked this pull request as draft December 6, 2023 00:39
@Annelisebx Annelisebx marked this pull request as ready for review December 6, 2023 07:46
Copy link
Contributor

@taylorpapke taylorpapke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing! In future iterations, I think we can change standard to just User to match the role it represents (or Creator). Also, we can probably get rid of the NSC Logo in the top left since this is non-customer facing and the back button is covering it.

Copy link
Contributor

@brinkbrink brinkbrink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work here. Taylor's suggestions for future iterations make sense. I also appreciate the comments in the code, makes it really easy to read through the logic and understand what you did...which makes it easier to review!

@brinkbrink
Copy link
Contributor

@Annelisebx Looks like there are still issues with signing commits here but given it's the last week of the quarter I'm just going to force merge.

@brinkbrink brinkbrink merged commit fea38e0 into main Dec 6, 2023
@brinkbrink brinkbrink deleted the enhancement-167-edit-user-role-01 branch December 6, 2023 17:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request Sprint 4
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

EDIT USER ROLE: Add Page and List All Users/Roles USER STORY: Admin View Edit User Role Page
4 participants