Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

belindas-closet-android_3_108_creator-view-page #233

Merged
merged 3 commits into from
Dec 7, 2023

Conversation

nickolasram
Copy link
Contributor

If the user logs in without Admin credentials, they should now be sent to the creator view page as opposed to the admin view page. I set up an alternate branch, enhancement-108-creator-view-page-demo which includes a checkbox that should have you sign in as a user as opposed to an admin and you can see this feature working.

Screenshot (5)

Here is the creator view page you should be sent to if you log in as a non-admin on this branch, enhancement-108-creator-view-page-1,
or have the "log in as user" box checked when logging in on the demo branch enhancement-108-creator-view-page-demo

@MuhammadNSC
Copy link
Contributor

This looks good

Copy link
Contributor

@taylorpapke taylorpapke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Signing in with the creator role routes to the creator view page while the admin role routes to the admin view page.

The user role also routes to the creator page. We will want to change this in a future iteration to restrict access to the creator view page. Maybe the client will want to have a user view in the future but for now this is an inactive role. At this point, it can only be used to restrict access from admin and creators by assigning them this lower role.

Copy link
Contributor

@brinkbrink brinkbrink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean and working as expected. Thank you!

Don't be afraid to sprinkle in comments with your code. It's something we're going to need to be more mindful of going forward since this project will eventually be maintained by people who are not us. But this is a team-wide issue we'll address next quarter.

@brinkbrink
Copy link
Contributor

@nickolasram If you could just suss out the conflicts we can merge. Thank you!

@nickolasram nickolasram merged commit bc47b66 into main Dec 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Sprint 3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants