belindas-closet-android_4_176_modify-product-update-page #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intisarosman1
requested review from
Ali-7s,
Annelisebx,
tinpham5614,
heosman,
taylorpapke,
Robel-003 and
MuhammadNSC
intisarosman1
requested review from
bcko,
Seiyaroo,
brinkbrink and
brandondombrowsky
taylorpapke
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
Awesome! Everything works great and I am able to add an objectId from my mongoDB for the handbag and it sets isHidden to true when I delete.
The only thing I think would be an improvement (in a future iteration) is to redirect (stay) on the update screen after successful deletion so that I can delete another item without having to click the edit icon button again.
|
This works well for me. It makes it easier to delete multiple products at the same time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #176
This PR modifies the product page so that pressing the edit button on the Product Details page redirects to the Update page where there is a delete button for each product in the category. The admin can then scroll and delete products one by one.
For manual testing purposes, update the handbag in the 'Accessories' category to be a 24-character hex string as the id in Datasource.kt because MongoDB generates the ObjectId in this format (will otherwise throw an invalid id error).
Related to User Story #183