Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

belinda-closet-android-220-revise-add-product-page-01 #223

Merged
merged 6 commits into from
Dec 6, 2023
Merged

belinda-closet-android-220-revise-add-product-page-01 #223

merged 6 commits into from
Dec 6, 2023

Conversation

tinpham5614
Copy link
Contributor

Resolves: #220

This PR will do:

  1. Add more drop-down fields using a reusable function
  2. Remove unnecessary fields and variables.
  3. Add a successful toast message if users upload the image.

Screenshot
image

@tinpham5614 tinpham5614 self-assigned this Nov 30, 2023
@tinpham5614 tinpham5614 marked this pull request as ready for review December 1, 2023 07:34
@tinpham5614 tinpham5614 requested a review from a team as a code owner December 1, 2023 07:34
heosman
heosman approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@heosman heosman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me!

taylorpapke
taylorpapke approved these changes Dec 2, 2023
View reviewed changes
Copy link
Contributor

@taylorpapke taylorpapke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Everything seems to be working fine.

@taylorpapke taylorpapke mentioned this pull request Dec 4, 2023
Closed
@taylorpapke taylorpapke merged commit 3df92a9 into main Dec 6, 2023
1 check passed
@taylorpapke taylorpapke deleted the feature-220-revise-product-fields-01 branch December 6, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taylorpapke taylorpapke taylorpapke approved these changes

@heosman heosman heosman approved these changes

@intisarosman1 intisarosman1 Awaiting requested review from intisarosman1

@MuhammadNSC MuhammadNSC Awaiting requested review from MuhammadNSC

@bcko bcko Awaiting requested review from bcko bcko is a code owner automatically assigned from SeattleColleges/leadership

@Seiyaroo Seiyaroo Awaiting requested review from Seiyaroo Seiyaroo is a code owner automatically assigned from SeattleColleges/leadership

@brinkbrink brinkbrink Awaiting requested review from brinkbrink brinkbrink is a code owner automatically assigned from SeattleColleges/leadership

@brandondombrowsky brandondombrowsky Awaiting requested review from brandondombrowsky brandondombrowsky is a code owner automatically assigned from SeattleColleges/leadership

@Robel-003 Robel-003 Awaiting requested review from Robel-003 Robel-003 is a code owner automatically assigned from SeattleColleges/leadership

Assignees

@tinpham5614 tinpham5614

Labels
Sprint 2
Projects
Belinda's Closet
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Product Button Functionality: Revise the Add Product Page by including all required fields.
3 participants
@tinpham5614 @heosman @taylorpapke