Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

belindas-closet-android_3_210_logout-button-on-admin-page #221

Merged
merged 3 commits into from
Dec 4, 2023

Conversation

nickolasram
Copy link
Contributor

resolves #210

Added an icon to the top of the admin page.
Clicking on the icon should:

  1. remove the "token" and "userRole" data stored locally
  2. navigate back to the home page
  3. pop up a toast confirming the user has logged out

Screenshot (3)

Copy link
Contributor

@tinpham5614 tinpham5614 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logout button will appear after login.
It works as expected.

Please update the branch before merging.

@taylorpapke
Copy link
Contributor

This is good but I will mention that this was an extra feature added to a user story that was assigned to another dev. While it is a nice feature to have, it is important to keep our issues within the scope of our user stories requirements.

@nickolasram
Copy link
Contributor Author

There seems to be problems with .github/dependabot.yml which just got updated a few hours ago and is keeping this branch from passing a check after it was updated to include that new version of the file.

@nickolasram nickolasram merged commit 8d85c45 into main Dec 4, 2023
1 check passed
@brinkbrink brinkbrink deleted the enhancement-210-logout-button branch December 6, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Creator View Page: Logout button
4 participants