Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

belinda-closet-android-04-218-reset-password-page-01 #219

Merged
merged 3 commits into from
Dec 5, 2023

Conversation

tinpham5614
Copy link
Contributor

@tinpham5614 tinpham5614 commented Nov 30, 2023

Resolves: #218
This PR will create a reset password page.
The page will have two text fields. In the first text field, users can input their new password and in the second one, users can confirm the new password that they entered. If both new passwords match, users will be redirected to the login page where they can log in with their new password.

Note:

  • Currently, the page has no functionality.
  • I relocated the text field box to the top of the screen to prevent it from being obstructed by the keyboard.

Screenshot:
image

@tinpham5614 tinpham5614 marked this pull request as ready for review November 30, 2023 07:30
@tinpham5614 tinpham5614 requested a review from a team as a code owner November 30, 2023 07:30
@tinpham5614 tinpham5614 self-assigned this Nov 30, 2023
@tinpham5614 tinpham5614 changed the title belinda-closet-android-04-reset-password-page-01 belinda-closet-android-04-218-reset-password-page-01 Nov 30, 2023
Copy link
Contributor

@taylorpapke taylorpapke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was able to manually route to the password reset page and test it out. Both fields are working properly and require both fields to be the same while meeting length requirements. Looks good!

@theGaryLarson theGaryLarson self-requested a review December 5, 2023 06:07
Copy link
Contributor

@theGaryLarson theGaryLarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm assuming there is no route here yet because the functionality hasn't been added yet.

@tinpham5614
Copy link
Contributor Author

tinpham5614 commented Dec 5, 2023

LGTM! I'm assuming there is no route here yet because the functionality hasn't been added yet.

Yes, I think after implementing the reset password feature in the back end, users will be redirected to this page via a reset password link.

@brinkbrink brinkbrink merged commit aa269e8 into main Dec 5, 2023
1 check passed
@brinkbrink brinkbrink deleted the feature-218-reset-password-page-01 branch December 5, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Password Reset Page: Create a reset password page
4 participants