Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

belinda-closet-android-04-207-add-button-image-picker #208

Merged
merged 5 commits into from
Nov 30, 2023

Conversation

tinpham5614
Copy link
Contributor

Resolves: #207

This PR will add the button image picker that will allow creators/admins to upload product images when adding new products to the application.

  1. Add button image picker
  2. Modified the page by adding Scaffold and LazyColumn to make the screen scrollable and avoid overlapping the Top App Bar.

Demo:

Running.Devices.-.belindas_closet.2023-11-28.14-30-59.mp4

@MuhammadNSC MuhammadNSC reopened this Nov 29, 2023
@MuhammadNSC
Copy link
Contributor

This is a nice feature. Users will now be able to upload images from their phone. There was some error in the AddProduct.kt page in the branch on line 390 for the imageUri, however the stimulater was still able to run.

Copy link
Contributor

@taylorpapke taylorpapke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I am able to choose a photo to add and display when I click inside the box for the photo picker button.

Copy link
Contributor

@brinkbrink brinkbrink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Tin. It is working as expected.

@brinkbrink
Copy link
Contributor

@tinpham5614 can you try the following for me to help me troubleshoot what is going on with this check being hung up:

git commit --amend --no-edit
git push --force-with-lease

This is a way to push an empty commit to trigger a re-build and hopefully the check won't hang up.

@tinpham5614 tinpham5614 force-pushed the feature-207-button_image_picker-01 branch from d472f50 to 965a995 Compare November 30, 2023 02:21
@brinkbrink brinkbrink merged commit e2373ee into main Nov 30, 2023
1 check passed
@brinkbrink brinkbrink deleted the feature-207-button_image_picker-01 branch November 30, 2023 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add Product Image: Add button image picker
4 participants