Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Belinda_Android_Sprint_2_189_Navbar_SignUp_Page #190

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Belinda_Android_Sprint_2_189_Navbar_SignUp_Page #190

merged 2 commits into from
Nov 24, 2023

Conversation

MuhammadNSC
Copy link
Contributor

resolves issue #74.
This issue will add a menu icon to the sign up page
Screenshot 2023-11-23 at 1 59 35 PM

@MuhammadNSC MuhammadNSC self-assigned this Nov 23, 2023
@MuhammadNSC MuhammadNSC requested a review from a team as a code owner November 23, 2023 22:01
taylorpapke
taylorpapke approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@taylorpapke taylorpapke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Hamburger icon is shown and does not crash app.

Robel-003
Robel-003 approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@Robel-003 Robel-003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! hamburger icon working

@Robel-003 Robel-003 merged commit 5214bff into main Nov 24, 2023
2 checks passed
@taylorpapke taylorpapke mentioned this pull request Nov 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robel-003 Robel-003 Robel-003 approved these changes

@taylorpapke taylorpapke taylorpapke approved these changes

@bcko bcko Awaiting requested review from bcko

@Annelisebx Annelisebx Awaiting requested review from Annelisebx

@tinpham5614 tinpham5614 Awaiting requested review from tinpham5614

@brinkbrink brinkbrink Awaiting requested review from brinkbrink

@brandondombrowsky brandondombrowsky Awaiting requested review from brandondombrowsky

@Seiyaroo Seiyaroo Awaiting requested review from Seiyaroo Seiyaroo is a code owner automatically assigned from SeattleColleges/leadership

Assignees

@MuhammadNSC MuhammadNSC

Labels
Sprint 2
Projects
Belinda's Closet
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MuhammadNSC @taylorpapke @Robel-003