Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USER_STORY_Navigation_Bar_#74: Issue(please closed this one) #185

Closed
wants to merge 40 commits into from

Conversation

kaimanasse15
Copy link
Contributor

Pull requests should follow a common structure for organizational purposes and quick readability.

Naming convention for PR titles

< repo > _ < sprint > _ < issue > _ < pr or issue name >

Example:
belindas-closet-android_2_5_landing-page
This would be for the belindas-closet-android repo, sprint 2, issue 5, with the name "landing page."\

When first submitting your pull request, make sure to assign it on github to your team members who will be responsible for validating your pull request and make sure there are no merge conflicts.

Assignees

After assigning to a particular member set, we can then assign it to a proper project if you are working across multiple repos. This is especially important for the above reason, and is a fantastic way to organize your pull requests without mixing up where they are intended to go.

Projects

We can also assign a label to the pull request. This lets your PM/PO/ etc know what this pull request applies to. This makes assessing what we're looking for very quick and easy as a Project Manager, or other leader within the team.

Labels

**When submitting your pull request, be descriptive in both your topic name (IntelliJ Configuration(s)) and also assign it to a numbered issue. In this case, we've assigned this #12, because at the time of creation, there were 11 issues, and this was the logical next number to assign it to.

PullComment

Ensure you include details. As I did the following: <insert steps, include images if applicable>

When submitting a comment for a pull request, please label your pull request as a solution to another issue.

For example, reference the below image, and what I have put into the comment that will resolve our number 12 issue of no .idea file that's ignored in our .gitignore file.

ResolvesComment

We also want to include unit tests if and when possible to make sure we're getting full coverage of our code. This will simulate a real world environment where tests are extremely important.

Unit Test Example

@kaimanasse15 kaimanasse15 changed the title USER_STORY_Navigation_Bar_#74: Issue USER_STORY_Navigation_Bar_#74: Issue(please closed this one) Nov 25, 2023
@taylorpapke taylorpapke deleted the staging branch November 25, 2023 20:58
@taylorpapke taylorpapke restored the staging branch November 25, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants