-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SeasyHQ test assignment - Ondrej Husar #1
Open
OHUSAR
wants to merge
25
commits into
SeasyHQ:main
Choose a base branch
from
OHUSAR:ondrej-husar
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- city - country - amenities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task bol zabavny, vyskusal som si niektore nove veci. Snazil som sa ho robit poriadne v ramci moznosti a rozsahu. O niektorych veciach, ktore nie su dotiahnute viem (niektore spomeniem).
Setup prebehol bez problemov. Jedina "zaludna" vec (resp. taka, co ste nezamyslali) bola, ze v
packages/be/src/root.ts
chybal vtypeDefs
amenity.schema
.Po setupe som sa musel vo viacerych veciach zorientovat. Vsetko bolo samozrejme pekne nasetupovane, cize to nebolo nic extra zlozite. Kazdopadne, prvy krat som pouzival niektore kniznice (a patterny), cize som si trochu pozeral
knex
,apollo-server
arelay
dokumentacie. Najpr. som si rozchodil niektore queries a testoval v Playgrounde, potom viac FE veci. Commitoval som viac-menej priebezne, cize aj v commitoch je vidno workflow a cca straveny cas.Pouzil som niektore komponenty z MUI (hlavne form components), ale core stylovania som spravil v sass + css-modules. Stranka by mala byt responzivna, aj ked som developoval desktop-first. Jediny vyrazny design bug o ktorom viem je ten, ze v poslednom riadku s 2mi kartickami (je tam
space-between
).Pri vytvarani novej mariny je vo formulare mapa. Na mape je marker a pri jeho posuvani sa nastavuje pomocou geocodingu mesto a stat. Zaroven sa pouziva poloha markera ako zem. vyska a sirka. Posuvanie markera nie je uplne uzasne UX + to tam nie je nikde vysvetlene. Zaroven, na backende je spravena validacia dat, ale na frontende nie je. Pri nespravnych parametroch to len vyhodi chybu.
Paginacia pri marinach je spravena na FE velmi
primitivneminimalisticky - iba sa zvacsujefirst
a refetchuju sa vsetky mariny. Na backende je spravena Connection, ale implementuje iba forward paginaciu. Aj ked som na backende spravil "query all marinas in a city" a "query all marinas in a country", nepridal som to ako dalsi endpoint/filter na FE, snad to tak staci.Nerobil som SSR a ani autentifikaciu. Stravil som na tom velku cast soboty a nedelu podvecer a vyzadovalo by to viac casu. Aj ked som uz tieto koncepty implementoval, pochopitelne tu je setup trochu iny :)
Ondrej
Feature Summary
use cases for frontend
nice to have:
simple ssr reactdom with rendertostream with koa (or next.js if you want to set it up)use cases for backend
nice to have:
account schema (requires mutation for account table)authentication + authorization for add marina mutation