Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PostgreSQL datetime and timestamp datatype are equivalent #69

Merged
merged 1 commit into from
Jun 26, 2022
Merged

PostgreSQL datetime and timestamp datatype are equivalent #69

merged 1 commit into from
Jun 26, 2022

Conversation

billy1624
Copy link
Member

@billy1624 billy1624 commented May 27, 2022 •
edited
Loading

PR Info

Breaking Changes

  • Timestamp datatype in PostgreSQL now maps to ColumnType::DateTime in SeaQuery

The SQL standard requires that writing just timestamp be equivalent to timestamp without time zone, and PostgreSQL honors that behavior.
https://www.postgresql.org/docs/current/datatype-datetime.html

@billy1624 billy1624 self-assigned this May 27, 2022
@billy1624 billy1624 force-pushed the pg-datetime-timestamp branch from 22b45fe to f77a7d8 Compare May 27, 2022 08:24
@billy1624 billy1624 mentioned this pull request May 27, 2022
Closed
@billy1624 billy1624 marked this pull request as ready for review May 27, 2022 08:36
@NOBLES5E
Copy link

Can we merge this?

@billy1624 billy1624 requested a review from tyt2y3 June 24, 2022 06:54
@tyt2y3
Copy link
Member

tyt2y3 commented Jun 26, 2022

Awesome!

@tyt2y3
Copy link
Member

tyt2y3 commented Jun 26, 2022

This is such a great finding

@tyt2y3 tyt2y3 merged commit 0f7e6dc into master Jun 26, 2022
@tyt2y3 tyt2y3 deleted the pg-datetime-timestamp branch June 26, 2022 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyt2y3 tyt2y3 Awaiting requested review from tyt2y3

Assignees

@billy1624 billy1624

Labels
None yet
Projects
SeaQL Dev Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Postgres timestamp column type
3 participants
@billy1624 @NOBLES5E @tyt2y3