-
-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sea orm rocket #2431
Update sea orm rocket #2431
Conversation
Error in
|
@sawa-ko Can you tell me in which situation you encounter this error? I'm currently using the branch of this pull request together with rocket |
Well... no situation, as I simply copied and pasted your code and the error appeared. But.. more info:
|
You have the If you look into #[cfg_attr(not(feature = "mock"), derive(Clone))]
pub enum DatabaseConnection { This is not something that has changed as part of this PR. You can try to also feature gate the derive of |
Oh, i see, btw, what about this #2451? |
I just saw that I received an email with failing tests. After looking at them they all seem to be unrelated to the changes from this PR. Is it enough to re-base this PR? Or should I wait until these errors/warnings are fixed on main (if they are not already)? |
sorry for the delay, yes let's try a rebase |
17dbcc3
to
06faee4
Compare
I just rebased this PR on the master branch. Does the CI only run when manually triggered? Please let me know if additional changes are required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you
I've released https://crates.io/crates/sea-orm-rocket/0.5.5 |
PR Info
This updates the dependencies of
sea-orm-rocket
and all rocket based examples.Building
sea-orm-rocket
works without any code changes.Running the unit test also works.
I have also run
rustclippy.sh
andrustfmt.sh
.This leads to a lot of changes which I did not include as they are not related to the updated dependencies.
The example
proxy_cloudflare_worker_example
does not work without adjustments to its dependencies which currently includes a patch for theworker
crate.I have also not included those changes as they are not related to the updated dependencies.
No issue was creates. This relates to this If required I can create an issue and link it here.
Dependencies:
Dependents:
New Features
Bug Fixes
Breaking Changes
Changes
sea-orm-rocket