Allow modifying the connection in migrations #2397
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Features
Add a function to allow modifying the database connection in migrations.
This allows configuring the database connection like you do in your real application. I'm currently using this to register sqlite functions.
Usage would be something like this:
Note: I didn't see a test for
run_cli
except in the examples, so I wasn't sure if/where to add a test.I also looked at adding it as a function to
MigratorTrait
but there we could at most accept a&DbConn
(which would allow my use case) but I think this way is more flexible. The closure is acceptingConnectOptions
so we can continue to use the same cli options andDATABASE_URL
var. But it still allows to modify it before creating the connection or throw it away and create your own, if needed.