DerivePartialModel: Allow specification of Entity via a Path in addition to as an Ident #2111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreppnow
force-pushed
the
fix/reppnj/allow-path-for-partial-model
branch
2 times, most recently
from
c116a1b to
4a4b11e
Compare
jreppnow
force-pushed
the
fix/reppnj/allow-path-for-partial-model
branch
from
4a4b11e to
0c5e8e8
Compare
tyt2y3
reviewed
Feb 28, 2024
|
I think the intent of this PR is mostly already covered by #2137 |
|
@tyt2y3 Yup, that one pretty much covers it! Sorry for taking a bit longer to respond, I will close this PR as it's been superseded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Info
Content: With the current implementation when deriving
DerivePartialModel, one must specify theEntitywhose columns should be used as anIdent- meaning that one must import it into the current scopeThis is somewhat unwieldy, especially when dealing with generated code, where one would prefer to just
usethe containing module, not the contents themselvesThis PR instead allows one to specify a
Path, meaning that no directuseis required anymoreTicket: Sorry, should have probably created a ticket first - does not exist atm, but can create one if necessary.
Bug Fixes
Entityto be specified as aPath, not just anIdent, alleviating the need to import the Entity struct whenever you want to use the DerivePartialModel macroBreaking Changes
Paths are a superset ofIdentsChanges