model_extra_derives to be also added to coresponding enums #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billy1624
reviewed
Mar 23, 2023
There was a problem hiding this comment.
Hey @gocmarek, thanks for reporting this problem and file a PR for it. I think we need extra documentation for this breaking changes. We should edit the help message of sea-orm-cli generate entity command and mention the --model-extra-derives string will also be applied to the generated active enums.
|
Any update on this @gocmarek, would like to see this landed too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As first thanks a lot for the job you are doing to deliver us this great piece of software!
As i see you have added extra option for sea-orm-cli "model_extra_derives" which is realy helping a lot and saving time - we don't need to add extra implementation of our code to have all needed derives.
...but there is a little problem because this option is not adding those derives to coresponding enums which is normally needed to be able to do some deeper mapping etc..
Please marge this PR to add this little gap, I think other people also need it.