Serialize time types as serde_json::Value
#1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried to implement a [custom active model](https://www.sea-ql.org/SeaORM/docs/advanced-query/custom-active-model/), and one of the columns was `Option<TimeDateTimeWithTimeZone>`. I got a compiler error: ``` error[E0277]: the trait bound `std::option::Option<sea_orm::prelude::TimeDateTimeWithTimeZone>: IntoActiveValue<_>` is not satisfied ``` Looking into the source code, it seemed a simple oversight that this trait was implemented for the `chrono` types but not the `time` types, and it was easy enough to fix since there's already a macro to implement it for new types. I also noticed that the `time` types are not accounted for in `src/query/json.rs` while the `chrono` types are, which I assume is also an oversight. However, I don't have a need for that at this point and the fix for that seemed less trivial, so I'm just bringing it to your attention. Thanks for SeaORM!
billy1624
force-pushed
the
into-json-time
branch
from
83232a4 to
fd93ea7
Compare
tyt2y3
reviewed
Oct 17, 2022
| "id": 1, | ||
| "date": "2022-03-13", | ||
| "time": "16:24:00", | ||
| "date_time": "2022-03-13T16:24:00", |
There was a problem hiding this comment.
I suspect we'd have the sub-second component?
tyt2y3
reviewed
Oct 17, 2022
| pub fn it_impl_try_from_u64<T: TryFromU64>() {} | ||
|
|
||
| #[allow(unused_macros)] | ||
| macro_rules! it_impl_traits { |
tyt2y3
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Info
In response to Implement
IntoActiveValuefortimetypes. #1041 (comment)Dependencies:
IntoActiveValuefortimetypes. #1041Adds
impl FromQueryResult for JsonValuenow serializetimetypes on MySQL and PostgreSQL results. For SQLite, its support for this should be added as part of [SeaORM] Supporttimecrate on SQLite #945