Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website Design #62

Merged
merged 2 commits into from
Mar 3, 2023
Merged

Website Design #62

merged 2 commits into from
Mar 3, 2023

Conversation

TroyKomodo
Copy link
Member

Proposed changes

Start the landing page using design from the Figma design

Closes #35

Types of changes

What types of changes does your code introduce to Scuffle?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further notes

Child of #47

@TroyKomodo TroyKomodo mentioned this pull request Feb 24, 2023
9 tasks
@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #62 (cb1944e) into main (b94956a) will decrease coverage by 0.08%.
The diff coverage is 86.96%.

@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
- Coverage   82.42%   82.34%   -0.08%     
==========================================
  Files          29       41      +12     
  Lines         438     1393     +955     
==========================================
+ Hits          361     1147     +786     
- Misses         77      246     +169     
Impacted Files Coverage Δ
common/src/config.rs 100.00% <ø> (ø)
common/src/lib.rs 100.00% <ø> (ø)
common/src/signal.rs 93.10% <ø> (ø)
common/src/types/channel.rs 0.00% <0.00%> (ø)
common/src/types/channel_ban.rs 0.00% <0.00%> (ø)
common/src/types/channel_role.rs 0.00% <0.00%> (ø)
common/src/types/channel_role_grant.rs 0.00% <0.00%> (ø)
common/src/types/chat_message.rs 0.00% <0.00%> (ø)
common/src/types/chat_room.rs 0.00% <0.00%> (ø)
common/src/types/follow.rs 0.00% <0.00%> (ø)
... and 28 more

Added the ability to login and register for new accounts with ServerSide
validation along a GQL API.

This PR used Cloudflare Turnstile as a captcha service to verify human
usage.

Special thanks to @SongoMen and @treuks for helping me with
isome UI functionality.

closes #36
@TroyKomodo TroyKomodo merged commit cb1944e into main Mar 3, 2023
@TroyKomodo TroyKomodo deleted the feature/website branch March 3, 2023 22:20
@IS2511
Copy link
Contributor

IS2511 commented Mar 6, 2023

This was never marked as ready for review so it never needed one... This doesn't seem like desirable behavior. @TroyKomodo every PR should probably be marked as ready for review before merging.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Landing Page
3 participants