Skip to content
This repository has been archived by the owner on Oct 10, 2021. It is now read-only.

Added ability to use package.json in different dir #7

Merged
merged 2 commits into from
Sep 17, 2020

Conversation

Bullrich
Copy link
Contributor

Added a parameter which allows to define the directory of the package.json if it's not in root.

The system will work by copying such package.json to the root of the cloned repository inside the action.

Added a parameter which allows to define the directory of the package.json if it's not in root.

The system will work by copying such package.json to the root of the cloned repository inside the action.
@Bullrich
Copy link
Contributor Author

Bullrich commented Sep 16, 2020

@ScottBrenner it seems that the Lint Code Base problem is failing for problems which I didn't cause and were there before. Should I change something there?

@ScottBrenner
Copy link
Owner

ScottBrenner commented Sep 16, 2020

Cool! Thanks for putting this together. Do you by chance have a sample workflow run that demonstrates this functionality? And don't worry about fixing the linter errors.

@Bullrich
Copy link
Contributor Author

Bullrich commented Sep 16, 2020

Do you by chance have a sample workflow run that demonstrates this functionality?

I did this same modification in the past in a different action: pascalgn/npm-publish-action#15 for getting a custom directory but it was in JS.

In the case of Shell I used $1 as in the Github official tutorial they are using it too for the only input that is being set up.

Copy link
Owner

@ScottBrenner ScottBrenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ScottBrenner ScottBrenner merged commit 688a332 into ScottBrenner:master Sep 17, 2020
@Bullrich Bullrich deleted the package-find branch September 17, 2020 06:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants