Skip to content
This repository has been archived by the owner on Oct 10, 2021. It is now read-only.

feat: adds custom tags values to generate changelog #26

Merged
merged 5 commits into from
Apr 1, 2021

Conversation

fsz-codeshop
Copy link
Contributor

The main objective here is to be able to pass FROM and TO tags to generate changelog. In case none is passes, fallback to the current case that gets last and last-1 tags via git command.

@ScottBrenner ScottBrenner self-requested a review March 29, 2021 14:33
@ScottBrenner ScottBrenner added the enhancement New feature or request label Mar 29, 2021
Copy link
Owner

@ScottBrenner ScottBrenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Please fix the linting errors - https://github.com/ScottBrenner/generate-changelog-action/runs/2218786841#step:4:89 - then I'll merge this in.

@fsz-codeshop
Copy link
Contributor Author

Done!
Changed from A && B || C to if A then B else C

@ScottBrenner
Copy link
Owner

ScottBrenner commented Mar 30, 2021

Thanks! I wonder if this might "overwrite"

if [ "$1" ] && [ "$1" != "package.json" ]; then
in the case where that input is not set but these inputs are. Would you be able to rewrite this line as well? If it's too much trouble, I'll look into it as well.

@fsz-codeshop
Copy link
Contributor Author

I am not sure if I understood what you meant on your question.
shell if [ "$1" ] && [ "$1" != "package.json" ]; then
This block seems ok as it is a "double if condition" that is not the same case as A && B || C.
Anyway, it would not "overwrite" (if I understood it right) any changes for this PR as they are related to different variables and there are no exit status.

If I missed what you meant please let me know =)

Copy link
Owner

@ScottBrenner ScottBrenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nevermind, LGTM!

@ScottBrenner ScottBrenner merged commit b134318 into ScottBrenner:master Apr 1, 2021
@ScottBrenner
Copy link
Owner

ScottBrenner commented Apr 1, 2021

https://github.com/ScottBrenner/generate-changelog-action/releases/tag/v1.2.0 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants