-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dev): GitHub Codespaces Configuration #46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some inline notes about the changes. If we think this looks good, I'll add details to https://github.com/ScottBrenner/cfn-lint-action#running-locally about using it! (also https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/setting-guidelines-for-repository-contributors)
@ScottBrenner nice work 💯 This is a good change! I think update the Running Locally section to include this option and we can look at getting this merged 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update Running Locally section 👍
Sure, how about changing "Running Locally" to "Development"?: 9dea936 |
Co-authored-by: Scott Brenner <[email protected]>
…for "GitHub Codespaces"
7eb5b18
to
9dea936
Compare
This Pull Request proposes a configuration for GitHub Codespaces, files created by Using a pre-built container configuration, see devcontainer.json reference for specifics.
When Codespaces becomes generally available, you will be billed for storage and compute usage, so I'll probably delete these configurations then .. but for now, this makes it easy to get up and running with developing for this Action - simply open the Codespace, it'll
npm install
automatically, and you're ready to go!: