Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dev): GitHub Codespaces Configuration #46

Merged
merged 5 commits into from
Apr 26, 2021

Conversation

ScottBrenner
Copy link
Owner

@ScottBrenner ScottBrenner commented Apr 24, 2021

This Pull Request proposes a configuration for GitHub Codespaces, files created by Using a pre-built container configuration, see devcontainer.json reference for specifics.

When Codespaces becomes generally available, you will be billed for storage and compute usage, so I'll probably delete these configurations then .. but for now, this makes it easy to get up and running with developing for this Action - simply open the Codespace, it'll npm install automatically, and you're ready to go!:

node ➜ /workspaces/cfn-lint-action (feature/github-codespaces-config ✗) $ node index.js 
[command]/usr/bin/python3 --version
Python 3.7.3
[command]/usr/bin/python3 -m venv /tmp/setup-cfn-lint-a1hciw/.venv
...
Successfully installed attrs-20.3.0 aws-sam-translator-1.35.0 boto3-1.17.57 botocore-1.20.57 cfn-lint-0.48.3 decorator-4.4.2 importlib-metadata-4.0.1 jmespath-0.10.0 jsonpatch-1.32 jsonpointer-2.1 jsonschema-3.2.0 junit-xml-1.9 networkx-2.5.1 pyrsistent-0.17.3 python-dateutil-2.8.1 pyyaml-5.4.1 s3transfer-0.4.2 six-1.15.0 typing-extensions-3.7.4.3 urllib3-1.26.4 zipp-3.4.1
::add-path::/tmp/setup-cfn-lint-a1hciw/bin
##[add-matcher]/workspaces/.github/cfn-lint.json

@ScottBrenner ScottBrenner added enhancement New feature or request docker Pull requests that update Docker code labels Apr 24, 2021
@ScottBrenner ScottBrenner requested a review from NickLiffen April 24, 2021 20:52
Copy link
Owner Author

@ScottBrenner ScottBrenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.devcontainer/Dockerfile Show resolved Hide resolved
.devcontainer/Dockerfile Outdated Show resolved Hide resolved
.devcontainer/Dockerfile Show resolved Hide resolved
.devcontainer/devcontainer.json Show resolved Hide resolved
@ScottBrenner ScottBrenner changed the title feat: GitHub Codespaces Configuration feat(dev): GitHub Codespaces Configuration Apr 24, 2021
@NickLiffen
Copy link
Collaborator

@ScottBrenner nice work 💯 This is a good change! I think update the Running Locally section to include this option and we can look at getting this merged 👍

Copy link
Collaborator

@NickLiffen NickLiffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update Running Locally section 👍

@ScottBrenner
Copy link
Owner Author

ScottBrenner commented Apr 25, 2021

Sure, how about changing "Running Locally" to "Development"?: 9dea936

@ScottBrenner ScottBrenner force-pushed the feature/github-codespaces-config branch from 7eb5b18 to 9dea936 Compare April 25, 2021 17:54
@ScottBrenner ScottBrenner merged commit e08b75e into main Apr 26, 2021
@ScottBrenner ScottBrenner deleted the feature/github-codespaces-config branch April 26, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Pull requests that update Docker code enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants