Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: copy capped minter for v2 #3

Closed
wants to merge 3 commits into from

Conversation

marcomariscal
Copy link

No description provided.

@marcomariscal marcomariscal linked an issue Dec 3, 2024 that may be closed by this pull request
3 tasks
/// @notice Error for when the caller is not the admin.
error ZkCappedMinterV2__Unauthorized(address account);

/// @notice Constructor for a new ZkCappedMinter contract
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should

Suggested change
/// @notice Constructor for a new ZkCappedMinter contract
/// @notice Constructor for a new ZkCappedMinterV2 contract

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix this in a followup

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool updating here:

e680c31

@alexkeating
Copy link
Collaborator

Feature branch for capped minter v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Capped minter V2 and V2 factory
2 participants