Code

feat: capped minter v2 nested testing#23

Code

Merged

alexkeating merged 92 commits intofeat/capped-minter-v2ScopeLift/zk-governance:feat/capped-minter-v2from feat/capped-minter-v2-nested-testing-no-hookScopeLift/zk-governance:feat/capped-minter-v2-nested-testing-no-hookCopy head branch name to clipboardDec 17, 2024

+202-51

Commits

Commits on Dec 3, 2024

• feat: copy capped minter for v2 template

  marcomariscal

  committed
  7e8117f

• feat: copy capped minter factory tests for v2

  marcomariscal

  committed
  d8da7d0

• feat: inherit from AccessControl and update accordingly

  marcomariscal

  committed
  12b292d

• feat: update tests to handle new auth functionality

  marcomariscal

  committed
  b597f72

• feat: add minter role

  marcomariscal

  committed
  2030897

• feat: test admin can't mint by default

  marcomariscal

  committed
  f9ed313

• fix: name

  marcomariscal

  committed
  7483d1f

Commits on Dec 4, 2024

• feat: basic pause functionality

  marcomariscal

  committed
  59bccb4

• feat: pause/unpause tests

  marcomariscal

  committed
  f5bb1a8

• fix: assume cap is not zero

  marcomariscal

  committed
  b85f60f

• fix: check for pauser role

  marcomariscal

  committed
  7eb43d0

• fix: separate role errors

  marcomariscal

  committed
  29362c9

• feat: _revertIfNotPauser

  marcomariscal

  committed
  b3e1cb4

• feat: close with tests

  marcomariscal

  committed
  a5c8e37

• fix: use _revertIfNotPauser

  marcomariscal

  committed
  29a35e0

• chore: better comment for close

  marcomariscal

  committed
  85bf41a

• feat: update with new time control params

  marcomariscal

  committed
  ab7a46d

• feat: time controls and tests

  marcomariscal

  committed
  01ee4e6

• fix: clearer expiration checks

  marcomariscal

  committed
  b309fb7

• chore: comment

  marcomariscal

  committed
  112421e

• fix: should be able to mint at start and at expiry

  marcomariscal

  committed
  fe1dbb4

• feat: inherit from AccessControl and update accordingly

  marcomariscal

  committed
  9f8ea6e

• feat: update tests to handle new auth functionality

  marcomariscal

  committed
  2aecdce

• feat: add minter role

  marcomariscal

  committed
  e293e2d

• feat: test admin can't mint by default

  marcomariscal

  committed
  b7f4222

• fix: name

  marcomariscal

  committed
  726d0bf

• fix: structure

  marcomariscal

  committed
  31d626f

• feat: basic pause functionality

  marcomariscal

  committed
  fb88648

• feat: pause/unpause tests

  marcomariscal

  committed
  946dc79

• fix: assume cap is not zero

  marcomariscal

  committed
  d9b3dba

• fix: check for pauser role

  marcomariscal

  committed
  1cfbef7

• fix: separate role errors

  marcomariscal

  committed
  3379852

• feat: _revertIfNotPauser

  marcomariscal

  committed
  004c789

• feat: close with tests

  marcomariscal

  committed
  4f29f5c

• fix: use _revertIfNotPauser

  marcomariscal

  committed
  edf05f6

• chore: better comment for close

  marcomariscal

  committed
  bceb0f7

• Merge branch 'feat/capped-minter-v2-close' into feat/capped-minter-v2-time-controls

  marcomariscal

  committed
  6251a0b

Commits on Dec 10, 2024

• chore: comment

  marcomariscal

  committed
  e680c31

• feat: _grantMinterRole helper

  marcomariscal

  committed
  6ee3fb1

• fix: use _checkRole and remove unused unauth error

  marcomariscal

  committed
  72ef93c

• fix: assume cap

  marcomariscal

  committed
  dd15cac

• fix: toml

  marcomariscal

  committed
  61e7247

• chore: format

  marcomariscal

  committed
  1295f88

• fix: import

  marcomariscal

  committed
  54315f5

• fix: compile

  marcomariscal

  committed
  2558249

• chore: name

  marcomariscal

  committed
  857ebc6

• fix: import

  marcomariscal

  committed
  479ef77

• fix: remove unnecessary

  marcomariscal

  committed
  007784b

• feat: _revertIfClosed

  marcomariscal

  committed
  bfbac0e

• Merge branch 'feat/capped-minter-v2-close' into feat/capped-minter-v2-time-controls

  marcomariscal

  committed
  1b290b7

• Merge branch 'feat/capped-minter-v2-minter-role' into feat/capped-minter-v2-pause and update to use oz errors

  marcomariscal

  committed
  8a5f057

• feat: _formatAccessControlError

  marcomariscal

  committed
  493c1a6

• Merge branch 'feat/capped-minter-v2-pause' into feat/capped-minter-v2-close

  marcomariscal

  committed
  7d84ebe

• fix: formatted error

  marcomariscal

  committed
  6bb7d1a

• Merge branch 'feat/capped-minter-v2-close' into feat/capped-minter-v2-time-controls

  marcomariscal

  committed
  e6a8718

Commits on Dec 11, 2024

• fix: remove assume cap greater than 0 in favor of bound

  marcomariscal

  committed
  fca3ffb

• fix: remove unnecessary assumptions

  marcomariscal

  committed
  93e4af3

• fix: use grant minter role

  marcomariscal

  committed
  225ba92

• fix: remove redundant balance check

  marcomariscal

  committed
  1942a64

• feat: refactor to set up capped minter in setup func

  marcomariscal

  committed
  77acf62

• feat: testFuzz_CorrectlyPausesMintsWhenTogglingPause

  marcomariscal

  committed
  ecb275d

• fix: move func

  marcomariscal

  committed
  43fa666

Commits on Dec 12, 2024

• Merge branch 'feat/capped-minter-v2-pause' into feat/capped-minter-v2-close

  marcomariscal

  committed
  7da3772

• fix: only admin can close, fix mint to zero addr receiver, and formatting default admin string error

  marcomariscal

  committed
  57e1f4f

• fix: remove unnecessary revert if closed when unpausing

  marcomariscal

  committed
  ef8ca96

• Update l2-contracts/src/ZkCappedMinterV2.sol

  Show description for 3fc7d3a
  

  marcomariscal

  and

  alexkeating

  authored
  3fc7d3a

• fix: test

  marcomariscal

  committed
  bb6854b

• fix: remove unnecessary pause from close

  marcomariscal

  committed
  0b17e88

• fix: use global minter

  marcomariscal

  committed
  7631a29

• Merge branch 'feat/capped-minter-v2-close' into feat/capped-minter-v2-time-controls

  marcomariscal

  committed
  b0da759

• fix: remove unnecessary cap bounds

  marcomariscal

  committed
  ffc248a

• fix: testFuzz_RevertIf_StartTimeAfterExpirationTime

  marcomariscal

  committed
  d1a7306

• fix: tests

  marcomariscal

  committed
  70b49f0

• fix: tests

  marcomariscal

  committed
  4b8499f

Commits on Dec 16, 2024

• feat: test_CorrectlyChangesClosedVarWhenCalledByAdmin

  marcomariscal

  committed
  246efdc

• fix: make start time and expiration time uint48

  marcomariscal

  committed
  37fe9e1

• fix: more readable default expiration distance

  marcomariscal

  committed
  083ef5f

• Merge branch 'feat/capped-minter-v2-close' into feat/capped-minter-v2-time-controls

  marcomariscal

  committed
  696bd69

• fix: foundry toml revert

  marcomariscal

  committed
  91c0ca8

• Merge branch 'feat/capped-minter-v2' into feat/capped-minter-v2-close

  marcomariscal

  committed
  aa47d27

• Merge branch 'feat/capped-minter-v2-close' into feat/capped-minter-v2-time-controls

  marcomariscal

  committed
  7a5e5a7

• feat: _grantMinterRoleToCappedMinter and nested minting tests

  marcomariscal

  committed
  eb0d858

Commits on Dec 17, 2024

• feat: testFuzz_NestedMintingContributesToParentCap

  marcomariscal

  committed
  fcc7c6a

• fix: _mintable and IMintable

  marcomariscal

  committed
  3441ce2

• Merge branch 'feat/capped-minter-v2' into feat/capped-minter-v2-nested-testing-no-hook

  marcomariscal

  committed
  15a6bf0

• chore: remove unused

  marcomariscal

  committed
  2d37a6e

• chore: comment clarity

  marcomariscal

  committed
  ec8c0db

• fix: remove unnecessary token minter role

  marcomariscal

  committed
  164ec5d

• feat: function testFuzz_ParentMintDoesNotCountAgainstChildCap(

  marcomariscal

  committed
  40c65fb

• fix: bounds

  marcomariscal

  committed
  15f79ac

• Merge branch 'feat/capped-minter-v2' into feat/capped-minter-v2-nested-testing-no-hook

  marcomariscal

  committed
  56d5719

• fix: params

  marcomariscal

  committed
  637ac39