feat: capped minter v2 nested testing #23
Merged
+202
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexkeating
reviewed
Dec 17, 2024
|
|
||
| // Child should be able to mint from parent | ||
| vm.prank(address(childMinter)); | ||
| parentMinter.mint(_receiver, _amount); |
There was a problem hiding this comment.
What we really want to test is that a minter on the child can mint from the child and that this minting consumes contributes towards the limit of the parent minter.
There was a problem hiding this comment.
Also, I would change some naming in the main contract to reference _mintable or something similar instead of token
marcomariscal
changed the base branch from
feat/capped-minter-v2-time-controls
to
feat/capped-minter-v2
6 tasks
alexkeating
reviewed
Dec 17, 2024
| _createCappedMinter(address(parentMinter), _childAdmin, _childCap, _startTime, _expirationTime); | ||
|
|
||
| _grantMinterRoleToCappedMinter(address(parentMinter)); | ||
| _grantMinterRoleToCappedMinter(address(childMinter)); |
There was a problem hiding this comment.
The child shouldn't need the minter role on the token
| @@ -167,6 +173,71 @@ contract Mint is ZkCappedMinterV2Test { | |||
| cappedMinter.mint(_receiver, _amount); | |||
| } | |||
|
|
|||
| function testFuzz_NestedMintingContributesToParentCap( | |||
There was a problem hiding this comment.
Maybe also add a test verifying the parent mint does not count against the child mint
alexkeating
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.