Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use OZ checkpointing library #20

Merged
merged 9 commits into from
Dec 2, 2022
Merged

Use OZ checkpointing library #20

merged 9 commits into from
Dec 2, 2022

Conversation

davidlaprade
Copy link
Contributor

Fixes #17

mds1
mds1 approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@mds1 mds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, optional syntax change

src/ATokenNaive.sol Outdated Show resolved Hide resolved
src/ATokenNaive.sol Outdated Show resolved Hide resolved
wildmolasses
wildmolasses approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@wildmolasses wildmolasses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment, otherwise lgtm

src/ATokenNaive.sol Outdated Show resolved Hide resolved
@davidlaprade davidlaprade merged commit 1cd6967 into master Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mds1 mds1 mds1 approved these changes

@wildmolasses wildmolasses wildmolasses approved these changes

@apbendi apbendi Awaiting requested review from apbendi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate usage of OZ checkpointing library instead of rolling our own in AToken
3 participants
@davidlaprade @wildmolasses @mds1