-
-
Notifications
You must be signed in to change notification settings - Fork 974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bun(-baseline): Add version 1.1.0 #5672
Conversation
/verify |
CC @chawyehsu |
All changes look good. Wait for review from human collaborators. bun-baseline
bun
|
1 similar comment
All changes look good. Wait for review from human collaborators. bun-baseline
bun
|
@chawyehsu Can you explain to me what it means to "leak" DLL imports? Perhaps the $IsBaseline = $ForceBaseline
if (!$IsBaseline) {
$IsBaseline = !( `
Add-Type -MemberDefinition '[DllImport("kernel32.dll")] public static extern bool IsProcessorFeaturePresent(int ProcessorFeature);' `
-Name 'Kernel32' -Namespace 'Win32' -PassThru `
)::IsProcessorFeaturePresent(40);
} |
That means leaking imported methods to the current PS session, literally. By directly using Yeah it's leaking the imported method as well. You may validate I realize Scoop Core/installer having the same problem though. |
Closes #5092