Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bun(-baseline): Add version 1.1.0 #5672

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Conversation

sitiom
Copy link
Contributor

@sitiom sitiom commented Apr 1, 2024

Closes #5092

@sitiom
Copy link
Contributor Author

sitiom commented Apr 1, 2024

/verify

@sitiom
Copy link
Contributor Author

sitiom commented Apr 1, 2024

CC @chawyehsu

Copy link
Contributor

github-actions bot commented Apr 1, 2024

All changes look good.

Wait for review from human collaborators.

bun-baseline

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

bun

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

1 similar comment
Copy link
Contributor

github-actions bot commented Apr 1, 2024

All changes look good.

Wait for review from human collaborators.

bun-baseline

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

bun

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@chawyehsu chawyehsu merged commit c4ec1a3 into ScoopInstaller:master Apr 2, 2024
2 checks passed
@sitiom sitiom deleted the bun branch April 2, 2024 01:28
@sitiom
Copy link
Contributor Author

sitiom commented Apr 2, 2024

@chawyehsu Can you explain to me what it means to "leak" DLL imports? Perhaps the bun.sh/install.ps1 script is leaking as well?

  $IsBaseline = $ForceBaseline
  if (!$IsBaseline) {
    $IsBaseline = !( `
      Add-Type -MemberDefinition '[DllImport("kernel32.dll")] public static extern bool IsProcessorFeaturePresent(int ProcessorFeature);' `
        -Name 'Kernel32' -Namespace 'Win32' -PassThru `
    )::IsProcessorFeaturePresent(40);
  }

@chawyehsu
Copy link
Member

chawyehsu commented Apr 2, 2024

"leak" DLL imports?

That means leaking imported methods to the current PS session, literally. By directly using Add-Type to load assemblies to current session there is no way to unload it unless starting a new session. In most cases, this won't cause issues as imported methods have namespaces specified, but one may not want to have imported methods persistent in current session.

Yeah it's leaking the imported method as well. You may validate [Win32.Kernel32]::IsProcessorFeaturePresent available after runing the install script.

I realize Scoop Core/installer having the same problem though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request]: Bun
2 participants