Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zulu enhancements #515

Merged
merged 7 commits into from
May 22, 2024
Merged

Zulu enhancements #515

merged 7 commits into from
May 22, 2024

Conversation

ryansuhartanto
Copy link
Contributor

Should resolves #514.

Copy link
Contributor

Your changes do not pass checks.

microsoft21-jdk

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

zulu-jdk

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

zulu-jre

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

zulufx-jdk

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

zulufx-jre

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@ryansuhartanto
Copy link
Contributor Author

ryansuhartanto commented Apr 23, 2024

I'll use this jsonpath to filter the version and product UUIDs

$..['distro_version','package_uuid']

And then I use regex to match it (example: https://regex101.com/r/bYBxsK/1)

\[\s*\[\s*(?<major>\d+),\s*(?<minor>\d+),\s*(?<patch>\d+),\s*\d\s*\],\s*"(?<amd64>[\w-]+)"(?:,\s*\[\s*(?:\d+,?\s*)+\],\s*"(?<i686>[\w-]+)")\s*\]

@ryansuhartanto
Copy link
Contributor Author

I think I found a bug when doing json_path.

$ json_path '[{"availability_type":"CA","distro_version":[17,48,15,0],"download_url":"https://cdn.azul.com/zulu/bin/zulu17.48.15-ca-fx-jre17.0.10-win_x64.zip","java_version":[17,0,10],"latest":true,"name":"zulu17.48.15-ca-fx-jre17.0.10-win_x64.zip","openjdk_build_number":7,"package_uuid":"cef00b50-77db-400a-afdd-b9e391e44631","product":"zulu"},{"availability_type":"CA","distro_version":[17,48,15,0],"download_url":"https://cdn.azul.com/zulu/bin/zulu17.48.15-ca-fx-jre17.0.10-win_i686.zip","java_version":[17,0,10],"latest":true,"name":"zulu17.48.15-ca-fx-jre17.0.10-win_i686.zip","openjdk_build_number":7,"package_uuid":"25351721-5e7e-4eef-a0ef-0c3686b38631","product":"zulu"}]' "$..['distro_version','package_uuid']" $null $false $false
[
  17,
  48,
  15,
  0
]\ncef00b50-77db-400a-afdd-b9e391e44631\n[
  17,
  48,
  15,
  0
]\n25351721-5e7e-4eef-a0ef-0c3686b38631

@ryansuhartanto ryansuhartanto marked this pull request as ready for review May 13, 2024 10:23
@ryansuhartanto
Copy link
Contributor Author

Product UUIDs is discarded using this technique, but this is the best I can do for the current Scoop version by utilizing include_fields.

@eijckron
Copy link

@se35710 You have approved most of the recent PR's. What is needed to get this PR merged?

@se35710
Copy link
Collaborator

se35710 commented May 22, 2024

@se35710 You have approved most of the recent PR's. What is needed to get this PR merged?

Just a little unsure about the JEP 449 and the removal of x86-32 binaries. Going to merge it now.

@se35710 se35710 merged commit 16a03df into ScoopInstaller:master May 22, 2024
2 checks passed
@se35710 se35710 mentioned this pull request May 22, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate from Zulu OpenJDK Discovery API to Azul Metadata API
3 participants