mambaforge: Fix installer script

[chortbauer]

As the 22.11.1-2 version of the mambaforge installer only installs into an empty directory, the installer is moved to the $env:TEMP directory befor installation. If the temporary path for the installer already exists, an error is thrown. After installation the installer is deleted as before.

Closes #10420

• I have read the Contributing Guide.

[c-ortbauer]

Full disclosure: I am the author of this PR.
I made this PR at home with my private account and tested it on Windows 11.
Now I have tested it on my work PC running Windows 10.

[jaimergp]

NSIS (what constructor uses to produce installers on Windows, hence Mambaforge) does not change the exit code if the installation fails (i.e. it always throws 0). Would it be worth it to add post-install check? For example, testing for the existence of python.exe.

[elovelan]

@jaimergp, I'll happily write that, but hopefully, we can get this merged to unblock it!

[elovelan]

@jaimergp, the NSIS docs indicate that NSIS should be able to return a failure exit code. I'm happy to dig into this more if there's a chance that updating constructor might resolve it. I realize that may be a risky proposition however if any software is relying on it always having a return code of 0, so I'm also happy to continue down the path of your original suggestion.

[jaimergp]

I'd happily review PRs in constructor, yes! Maybe we do have to throw some SetErrorLevel calls here and there. I am not sure how broad 2 - Installation aborted by script is either, but we'll get there. Thanks!

And yea, my suggestion shouldn't block this. We might have more than one issue (see recent comment) anyway.

[elovelan]

/verify

[github-actions]

Your changes do not pass checks.

mambaforge

• Description
• License
• Hashes
• Checkver
• Autoupdate
• Autoupdate Hash Extraction

[jasongodev]

Reminding myself to look at this again soon.

[jasongodev]

Please use:

"checkver": "github"