Add SSE client test for last-event-id mechanism
#5597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FirelightFlagboy
force-pushed
the
5511-sse-client-test-the-last-event-id-mechanism-works-when-connection-disconnects
branch
2 times, most recently
from
0cc429b to
12e89fd
Compare
FirelightFlagboy
force-pushed
the
5511-sse-client-test-the-last-event-id-mechanism-works-when-connection-disconnects
branch
from
1197c8d to
d84d46d
Compare
libparsec/crates/client_connection/src/authenticated_cmds/mod.rs
Outdated
Show resolved
Hide resolved
This was referenced Oct 24, 2023
FirelightFlagboy
force-pushed
the
5511-sse-client-test-the-last-event-id-mechanism-works-when-connection-disconnects
branch
from
0c98240 to
6deed54
Compare
touilleMan
requested changes
Oct 24, 2023
libparsec/crates/client_connection/src/authenticated_cmds/mod.rs
Outdated
Show resolved
Hide resolved
touilleMan
reviewed
Oct 24, 2023
touilleMan
reviewed
Oct 24, 2023
touilleMan
reviewed
Oct 24, 2023
FirelightFlagboy
force-pushed
the
5511-sse-client-test-the-last-event-id-mechanism-works-when-connection-disconnects
branch
from
6deed54 to
ec3ff75
Compare
FirelightFlagboy
force-pushed
the
5511-sse-client-test-the-last-event-id-mechanism-works-when-connection-disconnects
branch
2 times, most recently
from
6dd74c7 to
fc53c16
Compare
FirelightFlagboy
force-pushed
the
5511-sse-client-test-the-last-event-id-mechanism-works-when-connection-disconnects
branch
2 times, most recently
from
9c038aa to
5f0b3fe
Compare
FirelightFlagboy
force-pushed
the
5511-sse-client-test-the-last-event-id-mechanism-works-when-connection-disconnects
branch
from
5f0b3fe to
eb5d08e
Compare
TimeEngineer
approved these changes
Nov 27, 2023
touilleMan
reviewed
Nov 27, 2023
| @@ -44,8 +44,13 @@ log = { workspace = true } | |||
| [target.'cfg(not(target_arch = "wasm32"))'.dependencies] | |||
| # TODO: support SSE for Web | |||
| reqwest-eventsource = { workspace = true } | |||
| tokio = { workspace = true, features = ["net"] } | |||
There was a problem hiding this comment.
only used in test, so dev dependency ?
|
Let's keep this PR open until merge of #5691 |
|
@touilleMan @FirelightFlagboy this PR is linked to #5511 which is part of #4550 (currently on the V3 Roadmap). |
touilleMan
force-pushed
the
5511-sse-client-test-the-last-event-id-mechanism-works-when-connection-disconnects
branch
from
eb5d08e to
4321df1
Compare
This was
linked to
issues
Feb 25, 2024
touilleMan
approved these changes
Feb 25, 2024
touilleMan
deleted the
5511-sse-client-test-the-last-event-id-mechanism-works-when-connection-disconnects
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
SSEEventIDto validate the id received from the server. #5635