Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WinFSP to installer #6535

Closed
Tracked by #5137
Max-7 opened this issue Feb 27, 2024 · 0 comments · Fixed by #6676
Closed
Tracked by #5137

Add WinFSP to installer #6535

Max-7 opened this issue Feb 27, 2024 · 0 comments · Fixed by #6676
Assignees
@FirelightFlagboy
Labels
A-Client Area: Parsec desktop application A-Windows Area: Window issue
Milestone
v3.0-beta

Comments

@Max-7
Copy link
Contributor

Max-7 commented Feb 27, 2024 •
edited by FirelightFlagboy
Loading

To include WinFSP in the electron installer for Windows, we need to use a custom nsi script provide with nsis.script.

We could be inspired by what we have done previously installer.nsi

But we would need to setup the env beforehand (e.g.: downloading winfsp setup.exe that was done in freeze_program.py)

Fortunatly, electron-builder provide an API that could be used inside a js script: electron-build-api
@mmmarcos mmmarcos mentioned this issue Feb 27, 2024
Closed
@mmmarcos mmmarcos added this to the v3.0 milestone Feb 27, 2024
@mmmarcos mmmarcos mentioned this issue Feb 27, 2024
Closed
37 tasks
@mmmarcos mmmarcos added A-Windows Area: Window issue A-Linux Area: Linux issue labels Feb 27, 2024
@mmmarcos mmmarcos changed the title Add WinFSP / Fuse to installer Add WinFSP & Fuse to installer Feb 27, 2024
@mmmarcos mmmarcos mentioned this issue Mar 5, 2024
Closed
4 tasks
@FirelightFlagboy FirelightFlagboy changed the title Add WinFSP & Fuse to installer Add WinFSP to installer Mar 6, 2024
@FirelightFlagboy FirelightFlagboy added A-Client Area: Parsec desktop application and removed A-Linux Area: Linux issue labels Mar 6, 2024
FirelightFlagboy added a commit that referenced this issue Mar 7, 2024
@FirelightFlagboy
Convert the electron builder config from yaml to js file
9a90cdb 
Having a js file will enable further customization of the build process.
That capability will be used notably for #6535 to download `WinFSP` installer when building the Windows installer.
@FirelightFlagboy FirelightFlagboy mentioned this issue Mar 7, 2024
Merged
FirelightFlagboy added a commit that referenced this issue Mar 7, 2024
@FirelightFlagboy
Convert the electron builder config from yaml to js file
72ab6e6 
Having a js file will enable further customization of the build process.
That capability will be used notably for #6535 to download `WinFSP` installer when building the Windows installer.
FirelightFlagboy added a commit that referenced this issue Mar 7, 2024
@FirelightFlagboy
Convert the electron builder config from yaml to js file
a913d42 
Having a js file will enable further customization of the build process.
That capability will be used notably for #6535 to download `WinFSP` installer when building the Windows installer.
FirelightFlagboy added a commit that referenced this issue Mar 7, 2024
@FirelightFlagboy
Convert the electron builder config from yaml to js file
0dd5acb 
Having a js file will enable further customization of the build process.
That capability will be used notably for #6535 to download `WinFSP` installer when building the Windows installer.
FirelightFlagboy added a commit that referenced this issue Mar 8, 2024
@FirelightFlagboy
Convert the electron builder config from yaml to js file
4cee1f4 
Having a js file will enable further customization of the build process.
That capability will be used notably for #6535 to download `WinFSP` installer when building the Windows installer.
FirelightFlagboy added a commit that referenced this issue Mar 8, 2024
@FirelightFlagboy
Convert the electron builder config from yaml to js file
3e87683 
Having a js file will enable further customization of the build process.
That capability will be used notably for #6535 to download `WinFSP` installer when building the Windows installer.
FirelightFlagboy added a commit that referenced this issue Mar 8, 2024
@FirelightFlagboy
Convert the electron builder config from yaml to js file
48a7132 
Having a js file will enable further customization of the build process.
That capability will be used notably for #6535 to download `WinFSP` installer when building the Windows installer.
FirelightFlagboy added a commit that referenced this issue Mar 8, 2024
@FirelightFlagboy
Convert the electron builder config from yaml to js file
1db1a9e 
Having a js file will enable further customization of the build process.
That capability will be used notably for #6535 to download `WinFSP` installer when building the Windows installer.
FirelightFlagboy added a commit that referenced this issue Mar 8, 2024
@FirelightFlagboy
Convert the electron builder config from yaml to js file
bf9806c 
Having a js file will enable further customization of the build process.
That capability will be used notably for #6535 to download `WinFSP` installer when building the Windows installer.
FirelightFlagboy added a commit that referenced this issue Mar 8, 2024
@FirelightFlagboy
Convert the electron builder config from yaml to js file
3699ed5 
Having a js file will enable further customization of the build process.
That capability will be used notably for #6535 to download `WinFSP` installer when building the Windows installer.
FirelightFlagboy added a commit that referenced this issue Mar 8, 2024
@FirelightFlagboy
Convert the electron builder config from yaml to js file
bb57e25 
Having a js file will enable further customization of the build process.
That capability will be used notably for #6535 to download `WinFSP` installer when building the Windows installer.
FirelightFlagboy added a commit that referenced this issue Mar 11, 2024
@FirelightFlagboy
Convert the electron builder config from yaml to js file
61730bd 
Having a js file will enable further customization of the build process.
That capability will be used notably for #6535 to download `WinFSP` installer when building the Windows installer.
FirelightFlagboy added a commit that referenced this issue Mar 11, 2024
@FirelightFlagboy
Convert the electron builder config from yaml to js file
e034c87 
Having a js file will enable further customization of the build process.
That capability will be used notably for #6535 to download `WinFSP` installer when building the Windows installer.
FirelightFlagboy added a commit that referenced this issue Mar 11, 2024
@FirelightFlagboy
[fix #6535]: Add WinFSP installer to the Electron build
1c6089e 
- Use the electron-builder hook `boforePack` to download the WinFSP.
- Add a custom NSIS script to install WinFSP if it's not already installed.
FirelightFlagboy added a commit that referenced this issue Mar 11, 2024
@FirelightFlagboy
[fix #6535]: Add WinFSP installer to the Electron build
850f27d 
- Use the electron-builder hook `boforePack` to download the WinFSP.
- Add a custom NSIS script to install WinFSP if it's not already installed.
@FirelightFlagboy FirelightFlagboy linked a pull request Mar 11, 2024 that will close this issue
[fix #6535]: Add WinFSP installer to the Electron build #6676
Merged
FirelightFlagboy added a commit that referenced this issue Mar 11, 2024
@FirelightFlagboy
[fix #6535]: Add WinFSP installer to the Electron build
b53bf38 
- Use the electron-builder hook `boforePack` to download the WinFSP.
- Add a custom NSIS script to install WinFSP if it's not already installed.
github-merge-queue bot pushed a commit that referenced this issue Mar 12, 2024
@FirelightFlagboy
[fix #6535]: Add WinFSP installer to the Electron build
dc104a9 
- Use the electron-builder hook `boforePack` to download the WinFSP.
- Add a custom NSIS script to install WinFSP if it's not already installed.
FirelightFlagboy added a commit that referenced this issue Mar 12, 2024
@FirelightFlagboy
Convert the electron builder config from yaml to js file
185a66f 
Having a js file will enable further customization of the build process.
That capability will be used notably for #6535 to download `WinFSP` installer when building the Windows installer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FirelightFlagboy FirelightFlagboy

Labels
A-Client Area: Parsec desktop application A-Windows Area: Window issue
Projects
None yet
Milestone
v3.0-beta
Development

Successfully merging a pull request may close this issue.

[fix #6535]: Add WinFSP installer to the Electron build Scille/parsec-cloud
3 participants
@mmmarcos @Max-7 @FirelightFlagboy